Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nm team: Only show supported properties #984

Merged
merged 1 commit into from Mar 25, 2020
Merged

Conversation

cathay4t
Copy link
Member

Old code include everything get from teamd json config which
include unsupported options. The option link_watch might disappear
from time to time in teamd json config, this fails the verification
stage as the merge process will take this unsupported option to desired
state.

To properly solve that, only show supported properties:
* Team.Runner.NAME
* Team.Port.NAME

@coveralls
Copy link

coveralls commented Mar 25, 2020

Coverage Status

Coverage remained the same at ?% when pulling ff5cb1a on cathay4t:team_hide into 30d9691 on nmstate:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 76b6916 on cathay4t:team_hide into 220589a on nmstate:master.

Copy link
Member

@ffmancera ffmancera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Old code include everything get from teamd json config which
include unsupported options. The option `link_watch` might disappear
from time to time in teamd json config, this fails the verification
stage as the merge process will take this unsupported option to desired
state.

To properly solve that, only show supported properties:
    * Team.Runner.NAME
    * Team.Port.NAME

Signed-off-by: Gris Ge <fge@redhat.com>
EdDev
EdDev previously requested changes Mar 25, 2020
Copy link
Member

@EdDev EdDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we limit the report? Is it wrong?
I do not understand.

If the problem is with the verification, then we should not merge unsupported properties there, not in the report. i.e. we should not merge read-only properties.

@cathay4t
Copy link
Member Author

Why should we limit the report? Is it wrong?
I do not understand.

The update of teamd bring up bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1809050
https://bugzilla.redhat.com/show_bug.cgi?id=1808990

As we are showing arbitrary data read from teamd and that fail us on the merge and
verification.

If the problem is with the verification, then we should not merge unsupported properties there, not in the report. i.e. we should not merge read-only properties.

Unless start with _, people normally assume all showing data are supported and will be verified.
We are expecting github issue, bug report, customer support call if anything bug found for these unsupported properties caused by teamd changes.

@EdDev
Copy link
Member

EdDev commented Mar 25, 2020

Unless start with _, people normally assume all showing data are supported and will be verified.
We are expecting github issue, bug report, customer support call if anything bug found for these unsupported properties caused by teamd changes.

nmstate may report read-only values that are not editable, this is a documentation or internal warning work that can be done. If team is unstable, it may cause issues indeed, but choosing almost all-or-nothing is too drastic from my taste.
Nevertheless, I will not insist on this as I have little interest in team at the moment.

@EdDev EdDev dismissed their stale review March 25, 2020 09:11

Removing my vote.

@cathay4t cathay4t merged commit f1ed2a7 into nmstate:master Mar 25, 2020
@cathay4t cathay4t deleted the team_hide branch March 25, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'hwaddr' should not included in team option.
4 participants