New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nm team: Only show supported properties #984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
Old code include everything get from teamd json config which include unsupported options. The option `link_watch` might disappear from time to time in teamd json config, this fails the verification stage as the merge process will take this unsupported option to desired state. To properly solve that, only show supported properties: * Team.Runner.NAME * Team.Port.NAME Signed-off-by: Gris Ge <fge@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should we limit the report? Is it wrong?
I do not understand.
If the problem is with the verification, then we should not merge unsupported properties there, not in the report. i.e. we should not merge read-only properties.
The update of teamd bring up bugs: As we are showing arbitrary data read from teamd and that fail us on the merge and
Unless start with |
nmstate may report read-only values that are not editable, this is a documentation or internal warning work that can be done. If team is unstable, it may cause issues indeed, but choosing almost all-or-nothing is too drastic from my taste. |
Old code include everything get from teamd json config which
include unsupported options. The option
link_watch
might disappearfrom time to time in teamd json config, this fails the verification
stage as the merge process will take this unsupported option to desired
state.
To properly solve that, only show supported properties:
*
Team.Runner.NAME
*
Team.Port.NAME