Skip to content

Fix cargo clippy

Fix cargo clippy #5085

GitHub Actions / Test Results c9s-nm_1.42-integ_tier1 succeeded May 23, 2024 in 1s

252 passed, 0 failed and 13 skipped

Tests passed successfully

✅ junit.integ_tier1.xml

265 tests were completed in 303s with 252 passed, 0 failed and 13 skipped.

Test suite Passed Failed Skipped Time
pytest 252✅ 13⚪ 303s

✅ pytest

tests.integration.bond_test
  ✅ test_add_and_remove_bond_with_two_port
  ✅ test_remove_bond_with_minimum_desired_state
  ✅ test_add_bond_with_port_and_ipv4
  ✅ test_rollback_for_bond
  ✅ test_add_port_to_bond_without_port
  ✅ test_replace_bond_port
  ✅ test_remove_one_of_the_bond_port
  ✅ test_swap_port_between_bonds
  ✅ test_set_bond_mac_address
  ✅ test_changing_port_order_keeps_mac_of_existing_bond
  ✅ test_adding_a_port_keeps_mac_of_existing_bond
  ✅ test_adding_port_to_empty_bond_doesnt_keep_mac
  ✅ test_bond_with_empty_ipv6_static_address
  ✅ test_create_vlan_over_a_bond_port
  ✅ test_create_linux_bridge_over_bond
  ✅ test_preserve_bond_after_bridge_removal
  ✅ test_create_vlan_over_a_bond
  ✅ test_change_bond_option_miimon
  ✅ test_change_bond_option_with_an_id_value
  ✅ test_bond_mac_restriction_without_mac_in_desire
  ✅ test_bond_mac_restriction_in_desire_mac_in_current
  ✅ test_bond_fail_over_mac_follow
  ✅ test_create_bond_with_mac
  ✅ test_bond_with_arp_ip_target[192.0.2.1,192.0.2.2]
  ✅ test_bond_with_arp_ip_target[192.0.2.2,192.0.1.1]
  ✅ test_create_bond_with_default_miimon_explicitly
  ✅ test_change_2_port_bond_mode_from_1_to_5
  ✅ test_set_miimon_100_on_existing_bond
  ✅ test_bond_switch_mode_with_conflict_option
  ✅ test_remove_mode4_bond_and_create_mode5_with_the_same_port
  ✅ test_change_bond_mode_does_not_remove_child
  ✅ test_ignore_verification_error_on_invalid_bond_option
  ✅ test_create_bond_with_copy_mac_from
  ✅ test_bond_enable_and_disable_accept_all_mac_addresses
  ✅ test_bond_flip_tlb_dynamic_lbs
  ✅ test_bond_mac_restriction_check_only_impact_desired
  ✅ test_create_bond_with_copy_mac_from_bond_port_perm_hwaddr
  ✅ test_remove_bond_and_assign_ip_to_bond_port
tests.integration.dns_test
  ✅ test_dns_edit_nameserver_with_static_gateway[ipv4]
  ✅ test_dns_edit_nameserver_with_static_gateway[ipv6]
  ✅ test_dns_edit_ipv6_nameserver_before_ipv4
  ✅ test_dns_edit_3_more_nameservers[3ipv4]
  ✅ test_dns_edit_3_more_nameservers[3ipv6]
  ✅ test_dns_edit_3_more_nameservers[2ipv4+ipv6]
  ✅ test_dns_edit_3_more_nameservers[2ipv6+ipv4]
  ✅ test_dns_edit_3_more_nameservers[ipv4+ipv6+ipv4]
  ✅ test_dns_edit_3_more_nameservers[ipv6+ipv4+ipv6]
  ✅ test_dns_edit_3_more_nameservers[2ipv4+2ipv6]
  ✅ test_dns_edit_3_more_nameservers[2ipv6+2ipv4]
  ✅ test_remove_dns_config[empty_server_search_and_opt]
  ✅ test_remove_dns_config[empty_dict]
  ✅ test_change_dns_search_only
  ✅ test_dns_edit_nameserver_with_static_gateway_genconf[ipv4]
  ✅ test_dns_edit_nameserver_with_static_gateway_genconf[ipv6]
tests.integration.dynamic_ip_test
  ✅ test_ipv4_dhcp
  ✅ test_ipv6_dhcp_and_autoconf
  ✅ test_static_ip_with_auto_ip_enabled
  ✅ test_ipv4_dhcp_on_bond
  ✅ test_dhcp_on_bridge0
  ✅ test_port_ipaddr_learned_via_dhcp_added_as_static_to_linux_bridge
  ✅ test_dummy_disable_ip_stack_with_on_going_dhcp
  ✅ test_change_static_to_dhcp4_with_disabled_ipv6
  ✅ test_change_static_to_dhcp6_autoconf_with_disabled_ipv4
  ⚪ test_dummy_existance_after_dhcp_timeout[ipv4]
  ⚪ test_dummy_existance_after_dhcp_timeout[ipv6]
  ⚪ test_dummy_existance_after_dhcp_timeout[ipv4&6]
  ⚪ test_dummy_existance_after_ipv6_autoconf_timeout
  ✅ test_static_ip_with_routes_switch_back_to_dynamic
  ✅ test_wait_ip[any]
  ✅ test_wait_ip[ipv4]
  ✅ test_wait_ip[ipv6]
  ✅ test_wait_ip[ipv4+ipv6]
  ✅ test_ipv6_link_local_dns_srv
  ✅ test_auto_iface_with_static_routes
  ✅ test_auto_ip_with_pre_exist_address_without_dhcp_srv
  ✅ test_static_ipv6_route_not_covert_auto_ip
tests.integration.ethernet_mtu_test
  ✅ test_increase_iface_mtu
  ✅ test_decrease_iface_mtu
  ✅ test_upper_limit_jambo_iface_mtu
  ✅ test_set_mtu_on_two_vlans_with_a_shared_base
  ✅ test_change_mtu_with_stable_link_up
tests.integration.examples_test
  ✅ test_add_down_remove_vlan
  ✅ test_add_remove_ovs_bridge
  ✅ test_add_remove_ovs_bridge_bond
  ✅ test_add_remove_ovs_bridge_vlan
  ✅ test_add_remove_linux_bridge
  ✅ test_bond_linuxbridge_vlan
  ✅ test_dns_edit
  ✅ test_add_remove_routes
  ✅ test_add_remove_route_rule
  ✅ test_gen_conf_for_examples
  ✅ test_add_macsec_and_remove_example
  ⚪ test_add_hsr_and_remove_example
tests.integration.hostname_test
  ⚪ test_hostname_set_chg_and_clear
tests.integration.hsr_test
  ⚪ test_add_hsr_and_remove
tests.integration.linux_bridge_test
  ✅ test_create_and_remove_linux_bridge_with_two_ports
  ✅ test_remove_bridge_and_keep_port_up
  ✅ test_create_vlan_as_port_of_linux_bridge
  ✅ test_create_vlan_over_linux_bridge
  ✅ test_add_port_to_existing_bridge
  ✅ test_linux_bridge_uses_the_port_mac_implicitly
  ✅ test_linux_bridge_uses_specified_mac_address
  ✅ test_replace_port_on_linux_bridge
  ✅ test_activate_empty_bridge_does_not_blocked_by_dhcp
  ✅ test_change_linux_bridge_group_addr
  ✅ test_moving_ports_from_absent_interface
  ✅ test_create_linux_bridge_with_copy_mac_from
  ✅ test_linux_bridge_enable_and_disable_accept_all_mac_addresses
  ✅ test_linux_bridge_multicast_router[disabled_integer]
  ✅ test_linux_bridge_multicast_router[enabled_integer]
  ✅ test_linux_bridge_multicast_router[auto_integer]
  ✅ test_linux_bridge_multicast_router[disabled]
  ✅ test_linux_bridge_multicast_router[enabled]
  ✅ test_linux_bridge_multicast_router[auto]
  ✅ test_linux_bridge_show_port_ip_as_disabled
  ✅ test_linux_bridge_set_vlan_protocol[802.1ad]
  ✅ test_linux_bridge_set_vlan_protocol[802.1q]
  ✅ test_policy_create_bridge_by_description_of_port
tests.integration.macsec_test
  ✅ test_add_macsec_and_remove
  ✅ test_add_macsec_and_modify
  ⚪ test_macsec_offload
tests.integration.mem_leak_test
  ✅ test_libnmstate_show_fd_leak
  ✅ test_libnmstate_apply_fd_leak
tests.integration.nmstatectl_test
  ✅ test_manual_confirmation
  ✅ test_manual_rollback
  ✅ test_show_iface_include_route_and_rule
tests.integration.ovs_test
  ✅ test_create_and_remove_ovs_bridge_with_min_desired_state
  ✅ test_create_and_save_ovs_bridge_then_remove_and_apply_again
  ✅ test_create_and_remove_ovs_bridge_with_a_system_port
  ✅ test_create_and_remove_ovs_bridge_with_internal_port_static_ip_and_mac
  ✅ test_create_ovs_bridge_with_internal_port_with_copy_mac_from
  ✅ test_create_and_modify_ovs_bridge1_with_internal_port_same_name
  ✅ test_create_and_remove_ovs_bridge1_with_internal_port_same_name
  ✅ test_vlan_as_ovs_bridge_port
  ✅ test_ovs_interface_with_max_length_name
  ✅ test_change_ovs_interface_mac
  ✅ test_ovs_vlan_access_tag
  ✅ test_ovs_vlan_trunks
  ✅ test_remove_ovs_vlan_trunks
  ✅ test_create_internal_port_with_explict_mtu
  ✅ test_change_mtu_of_existing_internal_port
  ✅ test_create_ovs_with_internal_ports_in_reverse_order
  ✅ test_create_vlan_over_ovs_iface_with_use_same_name_as_bridge
  ✅ test_set_static_to_ovs_interface_with_the_same_name_bridge
  ✅ test_add_route_rule_to_ovs_interface_dhcp_auto_route_table
  ✅ test_attach_linux_bond_to_ovs_bridge
  ✅ test_ovs_vxlan_in_current_not_impact_others
  ✅ test_ovs_bond_other_config_and_remove
  ✅ test_ovs_bridge_other_config_and_remove
  ✅ test_ovs_sys_iface_other_config_and_remove
  ✅ test_netdev_data_path
  ✅ test_allow_extra_ovs_patch_ports
  ✅ test_ignore_ovs_geneve_iface
tests.integration.ovs_test.TestOvsLinkAggregation
  ✅ test_create_and_remove_lag
  ✅ test_create_lag_with_ports_in_reverse_order
  ✅ test_add_ovs_lag_to_existing_ovs_bridge
  ✅ test_add_ovs_lag_with_updelay_and_downdelay
  ✅ test_modify_ovs_lag_with_updelay_and_downdelay
tests.integration.ovs_test.TestOvsDpdk
  ⚪ test_create_ovs_dpdk_with_rx_queue
tests.integration.route_test
  ✅ test_add_static_routes
  ✅ test_add_static_route_without_next_hop_address
  ✅ test_add_static_route_with_route_type
  ✅ test_add_static_route_and_apply_route_absent
  ✅ test_add_static_Ipv4_route_with_route_type
  ✅ test_route_type_with_next_hop_interface
  ✅ test_apply_route_with_route_type_multiple_times
  ✅ test_add_gateway
  ✅ test_change_gateway
  ✅ test_remove_specific_route[ipv4]
  ✅ test_remove_specific_route[ipv6]
  ✅ test_remove_wildcast_route_with_iface[ipv4]
  ✅ test_remove_wildcast_route_with_iface[ipv6]
  ✅ test_remove_wildcast_route_without_iface[ipv4]
  ✅ test_remove_wildcast_route_without_iface[ipv6]
  ✅ test_disable_ipv4_and_remove_wildcard_route
  ✅ test_iface_down_with_routes_in_current[ipv4]
  ✅ test_iface_down_with_routes_in_current[ipv6]
  ⚪ test_static_route_with_empty_ip
  ✅ test_add_route_with_cwnd
  ✅ test_delete_route_with_cwnd
  ✅ test_remove_and_add_route_with_cwnd
  ✅ test_route_cwnd_without_lock_means_cwnd_none
  ✅ test_route_rule_add_without_from_or_to_or_family
  ✅ test_route_rule_add_from_only
  ✅ test_route_rule_add_to_only
  ✅ test_route_rule_add
  ✅ test_route_rule_add_without_priority
  ✅ test_route_rule_add_without_priority_apply_twice
  ✅ test_route_rule_fwmark_without_fwmask
  ✅ test_route_rule_fwmark_with_fwmask
  ✅ test_route_rule_from_all_to_all
  ✅ test_route_rule_from_all_to_all_ipv4
  ✅ test_route_rule_from_all_to_all_ipv6
  ✅ test_route_rule_add_and_remove_using_loopback
  ✅ test_delete_both_route_and_interface
  ✅ test_delete_both_route_rule_and_interface
  ✅ test_route_rule_iif
  ✅ test_route_rule_action
  ✅ test_preserve_unmanaged_routes
  ✅ test_add_and_remove_ecmp_route
tests.integration.static_ip_address_test
  ✅ test_add_static_ipv4_with_min_state
  ✅ test_remove_static_ipv4
  ✅ test_edit_static_ipv4_address_and_prefix
  ✅ test_add_static_ipv6_with_full_state
  ✅ test_add_static_ipv6_with_no_address
  ✅ test_disable_static_ipv6
  ✅ test_disable_static_ipv6_and_rollback
  ✅ test_enable_ipv6_and_rollback_to_disable_ipv6
  ✅ test_edit_static_ipv6_address_and_prefix
  ✅ test_modify_ipv4_with_reapply
  ✅ test_modify_ipv6_with_reapply
  ✅ test_get_ip_address_from_unmanaged_dummy
  ✅ test_preserve_ip_conf_if_not_mentioned
tests.integration.timeout_test
  ⚪ test_lot_of_vlans_with_bridges
tests.integration.veth_test.TestVeth
  ✅ test_add_veth_with_ethernet_peer
  ✅ test_add_with_peer_not_mentioned_in_desire
  ✅ test_add_and_remove_veth_kernel_mode
  ✅ test_add_veth_with_veth_peer_in_desire
  ✅ test_add_veth_as_bridge_port
  ✅ test_modify_veth_peer
  ✅ test_veth_as_vlan_base_iface
  ✅ test_veth_enable_and_disable_accept_all_mac_addresses
  ✅ test_veth_without_peer_fails
tests.integration.veth_test
  ✅ test_show_veth_as_veth_iface_type
tests.integration.vlan_test
  ✅ test_add_and_remove_vlan
  ✅ test_vlan_iface_uses_the_mac_of_base_iface
  ✅ test_two_vlans_on_eth1_change_mtu
  ✅ test_two_vlans_on_eth1_change_base_iface_mtu
  ✅ test_two_vlans_on_eth1_change_mtu_rollback
  ✅ test_add_vlan_and_modify_vlan_id
  ✅ test_vlan_enable_and_disable_accept_all_mac_addresses
tests.integration.vxlan_test
  ✅ test_add_and_remove_two_vxlans_on_same_iface
  ✅ test_add_and_remove_vxlan_without_base_if
  ✅ test_add_and_remove_vxlan_nolearning
  ✅ test_rollback_for_vxlans
  ✅ test_add_and_remove_vxlan_with_no_remote
  ✅ test_add_vxlan_and_modify_vxlan_id
  ✅ test_vxlan_enable_and_disable_accept_all_mac_addresses
tests.integration.nm.bond_test
  ✅ test_vlan_over_bond_reconnect_on_link_revive
tests.integration.nm.dns_test
  ⚪ test_rollback_on_global_dns
tests.integration.nm.gen_conf_test
  ✅ test_gen_conf_ovs_same_name
  ✅ test_gen_conf_routes_rules
tests.integration.nm.ieee802_1x_test
  ✅ test_eth_with_802_1x
  ✅ test_apply_ieee_802_1x_with_reserved_password
tests.integration.nm.linux_bridge_test
  ✅ test_bridge_consume_unmanaged_interface_as_port
  ✅ test_add_new_port_to_bridge_with_unmanged_port
  ✅ test_linux_bridge_over_vlan_of_bond_with_multiple_profile
  ✅ test_linux_bridge_does_not_lose_unmanaged_port_on_rollback
  ✅ test_linux_bridge_store_stp_setting_even_disabled
  ✅ test_reapply_does_not_reset_unmanaged_port_pvid
tests.integration.nm.ovs_test
  ✅ test_do_not_show_unmanaged_ovs_bridge
  ✅ test_create_vlan_over_existing_ovs_iface_with_use_same_name_as_bridge
  ✅ test_remove_ovs_internal_iface_got_port_profile_removed
  ✅ test_remove_ovs_bridge_ignored_port_keeps_it
  ✅ test_modify_state_with_ovs_dup_name_ovs_bridge_first_with_ipv4_dns
  ✅ test_modify_state_with_ovs_dup_name_ovs_interface_first_with_ipv4_dns
  ✅ test_remove_ovs_bridge_and_modify_ports
  ✅ test_remove_ovs_bridge_clean_up_system_port_also
  ✅ test_remove_same_name_ovs_bridge_clean_up_system_port_also
  ✅ test_purge_unmanged_ovs_bridge_in_show
tests.integration.nm.profile_test
  ✅ test_delete_inactive_profile
  ✅ test_nmstate_do_not_modify_conn_name
  ✅ test_ovs_dup_name_different_conn_name
  ✅ test_gen_conf_with_iface_state_down
tests.integration.nm.route_test
  ⚪ test_route_delayed_by_nm_fails