Fix division-by-zero while initializing CMAES #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While computing its default C decomposition frequency, under some conditions (e.g. with a problem of solution length 1000), initialization of CMAES failed due to division-by-zero. This commit aims to fix this issue.
engintoklu
requested review from
Higgcz,
pliskowski,
flukeskywalker and
NaturalGradient
Closed
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 77.83% 77.81% -0.03%
==========================================
Files 49 49
Lines 7332 7338 +6
==========================================
+ Hits 5707 5710 +3
- Misses 1625 1628 +3
|
Higgcz
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While computing its default C decomposition frequency, under some conditions (e.g. with a problem of solution length 1000), initialization of CMAES failed due to division-by-zero (which later resulted in a failing attempt to convert
infto an integer). This pull request aims to fix this issue.