Minor coding style changes.

app/helpers/versions_helper.rb

@@ -62,7 +62,7 @@ def summarize_changes(changes)
 
   # URL for link to object referenced by version.
   def url_for_object(object)
-    url_for case object.class.to_s
+    array = case object.class.to_s
     when 'Domain'
       [:edit, :admin, object]
     when 'Alias'
@@ -78,6 +78,8 @@ def url_for_object(object)
     else
       raise "No URL for object class '#{object.class.to_s}'."
     end
+
+    url_for array
   end
 
   # Convert changes YAML to hash just containing the new values.

app/models/domain.rb

@@ -18,7 +18,7 @@ class Domain < ActiveRecord::Base
 
   has_paper_trail
 
-  before_save ->{ name.downcase! }
+  before_save -> { name.downcase! }
 
   # Aliases count for simple_form.
   def aliases_count

test/functional/admin/aliases_controller_test.rb

@@ -36,7 +36,7 @@ class Admin::AliasesControllerTest < ActionController::TestCase
           end
 
           should respond_with :redirect
-          should set_the_flash.to /created/i
+          should set_the_flash.to(/created/i)
         end
 
         context 'to update' do
@@ -59,7 +59,7 @@ class Admin::AliasesControllerTest < ActionController::TestCase
           end
 
           should respond_with :redirect
-          should set_the_flash.to /successfully updated/i
+          should set_the_flash.to(/successfully updated/i)
         end
       end
 
@@ -74,7 +74,7 @@ class Admin::AliasesControllerTest < ActionController::TestCase
         end
 
         should respond_with :redirect
-        should set_the_flash.to /successfully destroyed/i
+        should set_the_flash.to(/successfully destroyed/i)
       end
     end
   end

test/functional/admin/mailboxes_controller_test.rb

@@ -58,7 +58,7 @@ class Admin::MailboxesControllerTest < ActionController::TestCase
           end
         end
 
-        should respond_with(:redirect)
+        should respond_with :redirect
         should set_the_flash.to(/created/i)
       end
 
@@ -80,7 +80,7 @@ class Admin::MailboxesControllerTest < ActionController::TestCase
           assert !Mailbox.where(username: @mailbox.username, domain_id: @domain_id).first
         end
 
-        should respond_with(:redirect)
+        should respond_with :redirect
         should set_the_flash.to(/successfully updated/i)
       end
     end
@@ -95,7 +95,7 @@ class Admin::MailboxesControllerTest < ActionController::TestCase
         assert !Mailbox.where(username: @mailbox.username, domain_id: @mailbox.domain_id).first
       end
 
-      should respond_with(:redirect)
+      should respond_with :redirect
       should set_the_flash.to(/successfully destroyed/i)
     end
   end
@@ -145,7 +145,7 @@ class Admin::MailboxesControllerTest < ActionController::TestCase
             assert Mailbox.where(username: @new_mailbox.username, domain_id: @domain_id).first
           end
 
-          should respond_with(:redirect)
+          should respond_with :redirect
           should set_the_flash.to(/created/i)
         end
 
@@ -165,7 +165,7 @@ class Admin::MailboxesControllerTest < ActionController::TestCase
             assert !Mailbox.where(username: @new_mailbox.username, domain_id: @domain_id).first
           end
 
-          should respond_with(:redirect)
+          should respond_with :redirect
           should set_the_flash.to(/successfully updated/i)
         end
       end
@@ -180,7 +180,7 @@ class Admin::MailboxesControllerTest < ActionController::TestCase
           assert !Mailbox.where(username: @new_mailbox.username, domain_id: @domain_id).first
         end
 
-        should respond_with(:redirect)
+        should respond_with :redirect
         should set_the_flash.to(/successfully destroyed/i)
       end
     end
@@ -224,7 +224,7 @@ class Admin::MailboxesControllerTest < ActionController::TestCase
             assert Mailbox.where(username: @new_mailbox.username, domain_id: @domain_id).first
           end
 
-          should respond_with(:redirect)
+          should respond_with :redirect
           should set_the_flash.to(/created/i)
         end
 
@@ -244,7 +244,7 @@ class Admin::MailboxesControllerTest < ActionController::TestCase
             assert !Mailbox.where(username: @new_mailbox.username, domain_id: @domain_id).first
           end
 
-          should respond_with(:redirect)
+          should respond_with :redirect
           should set_the_flash.to(/successfully updated/i)
         end
       end
@@ -259,7 +259,7 @@ class Admin::MailboxesControllerTest < ActionController::TestCase
           assert !Mailbox.where(username: @new_mailbox.username, domain_id: @domain_id).first
         end
 
-        should respond_with(:redirect)
+        should respond_with :redirect
         should set_the_flash.to(/successfully destroyed/i)
       end
     end

test/functional/admin/permissions_controller_test.rb

@@ -49,7 +49,7 @@ def delete_to_destroy
             .first
         end
 
-        should respond_with(:redirect)
+        should respond_with :redirect
         should set_the_flash.to(/created/i)
       end
 
@@ -77,7 +77,7 @@ def delete_to_destroy
             .first
         end
 
-        should respond_with(:redirect)
+        should respond_with :redirect
         should set_the_flash.to(/successfully updated/i)
       end
     end
@@ -95,7 +95,7 @@ def delete_to_destroy
           .first
       end
 
-      should respond_with(:redirect)
+      should respond_with :redirect
       should set_the_flash.to(/successfully destroyed/i)
     end
   end
@@ -141,7 +141,7 @@ def delete_to_destroy
               .first
           end
 
-          should respond_with(:redirect)
+          should respond_with :redirect
           should set_the_flash.to(/created/i)
         end
 
@@ -169,7 +169,7 @@ def delete_to_destroy
               .first
           end
 
-          should respond_with(:redirect)
+          should respond_with :redirect
           should set_the_flash.to(/successfully updated/i)
         end
       end
@@ -187,7 +187,7 @@ def delete_to_destroy
             .first
         end
 
-        should respond_with(:redirect)
+        should respond_with :redirect
         should set_the_flash.to(/successfully destroyed/i)
       end
     end

test/functional/admin/test_helper.rb

@@ -1,3 +1,4 @@
+# Create a dummy Mailbox and sign it in.
 def create_and_sign_in_mailbox
   @mailbox = FactoryGirl.create :mailbox, admin: true
   @domain_id = @mailbox.domain_id