Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility errors with recent Node.js versions #75

Closed
ndr0n opened this issue Nov 13, 2023 · 4 comments
Closed

Compatibility errors with recent Node.js versions #75

ndr0n opened this issue Nov 13, 2023 · 4 comments
Assignees
Labels
bug Something isn't working dependency

Comments

@ndr0n
Copy link

ndr0n commented Nov 13, 2023

Hey! I was trying to run facet but i get an issue on Ubuntu 22.04 when i run -> npm run facet after npm install.

the error that i get is the following:

TypeError: Cannot set property navigator of # which has only a getter
at Object. (/home/esquilo/Storage/Programs/facet/node_modules/webmidi/dist/cjs/webmidi.cjs.min.js:445:4390)
at Module._compile (node:internal/modules/cjs/loader:1376:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
at Module.load (node:internal/modules/cjs/loader:1207:32)
at Module._load (node:internal/modules/cjs/loader:1023:12)
at Module.require (node:internal/modules/cjs/loader:1235:19)
at require (node:internal/modules/helpers:176:18)
at Object. (/home/esquilo/Storage/Programs/facet/js/transport.js:4:19)
at Module._compile (node:internal/modules/cjs/loader:1376:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)

Node.js v21.1.0

Any help on making this run would be appreciated!

Thanks :)

@nnirror nnirror self-assigned this Nov 13, 2023
@nnirror
Copy link
Owner

nnirror commented Nov 13, 2023

@ndr0n Thanks for adding this! I am able to duplicate this after installing Node v21.1.0.

I had been using v14.20.0 up to this point. So, as a workaround, if you change Node versions to v14.20.0, it should (hopefully) run on Ubuntu without this error.

But I will, of course, keep this issue so I can fix this error for newer Node versions.

@nnirror nnirror changed the title Ubuntu - Node - webmidi Issue Compatibility errors with recent Node.js versions Nov 13, 2023
@nnirror nnirror added bug Something isn't working dependency labels Nov 13, 2023
@nnirror
Copy link
Owner

nnirror commented Nov 14, 2023

I have submitted a ticket to the WebMIDI repo, as after some more testing and process of elimination, I believe the issue is coming from the recently released node versions, and the webmidi npm package.

@nnirror
Copy link
Owner

nnirror commented Nov 21, 2023

Hey @ndr0n FYI if you want to use node v21 with Facet instead of switching to an older node version, you can.

To do so, edit the "scripts" object in package.json to look like this:

"scripts": {
    "facet": "node --no-experimental-global-navigator js/process_manager.js"
  }

I'm going keep this open until the fix goes out for WebMIDI, as they are still looking into it.

@nnirror
Copy link
Owner

nnirror commented Nov 24, 2023

@ndr0n Facet v1.1.6 was just released. It contains the updated WebMIDI package that has been fixed to address this issue. I just tested it on my local machine and it's working with Node v21.1.0 for me. Hopefully this fixes it for you. Thanks for pointing this out!

@nnirror nnirror closed this as completed Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependency
Projects
None yet
Development

No branches or pull requests

2 participants