[filter/tvm] Fix dimension order and add custom prop #3342
Conversation
kimjh12
requested review from
again4you,
anyj0527,
dongju-chae,
gichan-jang,
helloahn,
jaeyun-jung,
jijoongmoon,
kparichay,
leemgs,
lhs8928,
myungjoo,
wooksong,
zhoonit and
a team
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3342. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/. |
kimjh12
force-pushed
the
tvm-fix
branch
2 times, most recently
from
1a26e8f
to
7564a4f
Compare
| @@ -162,7 +161,15 @@ tvm_subplugin::parse_custom_prop (const char *custom_prop) | |||
| nns_loge ("Unknown device (%s).", option[1]); | |||
| invalid_option = true; | |||
| } | |||
| } else { | |||
| } else if (g_ascii_strcasecmp (option[0], "num_input") == 0) { | |||
| inputInfo.num_tensors = MIN ( atoi (option[1]), NNS_TENSOR_SIZE_LIMIT ); | |||
There was a problem hiding this comment.
prevent security report later
recommend to use g_ascii_strtoull() (atoi() is obsolescent function)
see https://wiki.sei.cmu.edu/confluence/display/c/MSC24-C.+Do+not+use+deprecated+or+obsolescent+functions
(guint) g_ascii_strtoull (option[1], NULL, 10);
There was a problem hiding this comment.
Fixed!! Thanks for the info
|
For TVM community, you may suggest (and implement) new API or new options for "get num inputs" API. |
Bug fix: inversed dimension order Add custom prop `num_input_tensors` - Since `get_num_inputs` API for tvm model returns (#inputs + #params), user should specify only #inputs Signed-off-by: Junhwan Kim <jejudo.kim@samsung.com>
Sounds great. (FYI : https://discuss.tvm.apache.org/t/10238) |
Bug fix: inversed dimension order
Add custom prop
num_input_tensorsget_num_inputsAPI for tvm model returns (#inputs + #params), user should specify only #inputs(Add 'get_num_inputs' to GraphRuntime apache/tvm#6118 (comment))
Signed-off-by: Junhwan Kim jejudo.kim@samsung.com
Self evaluation: