[Gst/MQTT] Introduce the Unix epoch synchronization using NTP @open sesame 09/29 10:29 #3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3427. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/. |
cibot: 
wooksong
force-pushed
the
ntp-sync-support
branch
from
3c9c825
to
04f070f
Compare
wooksong
force-pushed
the
ntp-sync-support
branch
from
04f070f
to
499cb02
Compare
|
CC: @anyj0527 @gichan-jang @kimjh12 You all need to study and understand this. |
wooksong
force-pushed
the
ntp-sync-support
branch
from
499cb02
to
da5c9d5
Compare
|
|
wooksong
force-pushed
the
ntp-sync-support
branch
from
da5c9d5
to
78d4b39
Compare
wooksong
requested review from
again4you,
anyj0527,
dongju-chae,
gichan-jang,
helloahn,
jaeyun-jung,
jijoongmoon,
kimjh12,
kparichay,
leemgs,
lhs8928,
myungjoo,
zhoonit and
a team
as code owners
gichan-jang
reviewed
Aug 27, 2021
gichan-jang
reviewed
Aug 27, 2021
anyj0527
reviewed
Aug 30, 2021
dongju-chae
reviewed
Sep 2, 2021
dongju-chae
reviewed
Sep 2, 2021
wooksong
force-pushed
the
ntp-sync-support
branch
from
78d4b39
to
99ea021
Compare
|
jaeyun-jung
reviewed
Sep 28, 2021
wooksong
force-pushed
the
ntp-sync-support
branch
2 times, most recently
from
0ef899f
to
710dfcc
Compare
This patch adds the implementation of the basic utility functions to get timestamps from the given or public NTP servers. Signed-off-by: Wook Song <wook16.song@samsung.com>
This patch introduces the self-synchronization mechanism of the Unix epoch timestamps. Note that if the 'ntp-sync' property is set to true (which means that if this feature is enabled), the pipeline would be stuck after a while. This is because most of the public NTP servers restrict clients not to poll too frequently. To fix it, polling intervals and caching mechanisms should be applied to the NPT utility functions. Signed-off-by: Wook Song <wook16.song@samsung.com>
jaeyun-jung
approved these changes
Sep 29, 2021
gichan-jang
changed the title
gichan-jang
changed the title
|
Merge after #3509 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces utility functions to get timestamps from the given NTP server and the self-synchronization mechanism of the Unix epoch timestamps using them.
To resolve the following issue, this PR also includes a patch to apply caching mechanism according to the polling interval given from the NTP server.
Signed-off-by: Wook Song wook16.song@samsung.com
Self evaluation: