Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[armnn] compilation error - unused parameter #3522

Merged
merged 1 commit into from
Oct 14, 2021
Merged

[armnn] compilation error - unused parameter #3522

merged 1 commit into from
Oct 14, 2021

Conversation

jvuillaumier
Copy link

correction for occurences of compilation error below, when compilation
switch ENABLE_ARMNN_CAFFE is disabled :
error: unused parameter '[parameter name]' [-Werror=unused-parameter]

Self evaluation:
SSAT: passed
Gtest armnn: passed

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 14, 2021

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3522. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

gichan-jang
gichan-jang approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@gichan-jang gichan-jang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The CI server's test failure is not related to this PR.

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 14, 2021

:octocat: cibot: @jvuillaumier, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3522-202110141859170.86095809936523-6d66e7eed4523d83fec2c73dab8c30545b878328/.

@gichan-jang
Copy link
Member

Please rebase with the latest code version. Then you will pass the test.

@again4you
Copy link
Collaborator

First of all, thank you for your patch.
Your work is OK. However, some test cases of MQTTSink Element are updated. Because of this reason, the related test cases are failed.

So please rebase the latest code and submit it again.

@jvuillaumier
[armnn] compilation error - unused parameter
21da35d 
correction for occurences of compilation error below, when compilation
switch ENABLE_ARMNN_CAFFE is disabled.

error: unused parameter '[parameter name]' [-Werror=unused-parameter]

Signed-off-by: Julien Vuillaumier <julien.vuillaumier@nxp.com>
@jvuillaumier jvuillaumier force-pushed the armnn-caffe-disabled-build-error branch from 6d66e7e to 21da35d Compare October 14, 2021 10:53
@jvuillaumier
Copy link
Author

Thank you for the comments.
Patch updated after rebase on top of main branch.

taos-ci
taos-ci approved these changes Oct 14, 2021
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jvuillaumier, 💯 All CI checkers are successfully verified. Thanks.

again4you
again4you approved these changes Oct 14, 2021
View reviewed changes
Copy link
Collaborator

@again4you again4you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@jvuillaumier
Copy link
Author

Please rebase with the latest code version. Then you will pass the test.

done

@jvuillaumier
Copy link
Author

First of all, thank you for your patch. Your work is OK. However, some test cases of MQTTSink Element are updated. Because of this reason, the related test cases are failed.

So please rebase the latest code and submit it again.

done

@jaeyun-jung jaeyun-jung merged commit d7265ed into nnstreamer:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@again4you again4you again4you approved these changes

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@taos-ci taos-ci taos-ci approved these changes

@gichan-jang gichan-jang gichan-jang approved these changes

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@dongju-chae dongju-chae Awaiting requested review from dongju-chae

@helloahn helloahn Awaiting requested review from helloahn

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@kimjh12 kimjh12 Awaiting requested review from kimjh12

@kparichay kparichay Awaiting requested review from kparichay

@leemgs leemgs Awaiting requested review from leemgs

@lhs8928 lhs8928 Awaiting requested review from lhs8928

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

Assignees
No one assigned
Labels
REBASE REQUIRED
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jvuillaumier @taos-ci @gichan-jang @again4you @jaeyun-jung