-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[svace] fix svace issue #3525
[svace] fix svace issue #3525
Conversation
Fix svace issue - allocation with invalid size param - possible int underflow Signed-off-by: Jaeyun <jy1210.jung@samsung.com>
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3525. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -1176,13 +1176,12 @@ gst_mqtt_sink_set_mqtt_ntp_srvs (GstMqttSink * self, const gchar * pairs) | |||
goto err_free_pair_arrs; | |||
|
|||
g_free (self->mqtt_ntp_hnames); | |||
self->mqtt_ntp_hnames = | |||
g_try_malloc0 (hnum * sizeof (*self->mqtt_ntp_hnames)); | |||
self->mqtt_ntp_hnames = g_try_malloc0 ((hnum + 1) * sizeof (gchar *)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
recv_frac = ntohl (packet.xmit_ts.frac); | ||
|
||
/** | ||
* @note NTP uses an epoch of January 1, 1900 while the Unix epoch is | ||
* the number of seconds that have elapsed since January 1, 1970. For this | ||
* reason, we subtract 70 years worth of seconds from the seconds since 1900 | ||
*/ | ||
if (recv_sec <= NTPUTIL_TIMESTAMP_DELTA) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jaeyun-jung Do you need this for 2.0.y and Tizen 6.5 M2 release? |
@myungjoo No. SE only checks the |
Fix svace issue
Signed-off-by: Jaeyun jy1210.jung@samsung.com