Fix #3440, macos build issues #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myungjoo
requested review from
again4you,
anyj0527,
dongju-chae,
gichan-jang,
helloahn,
jaeyun-jung,
jijoongmoon,
kimjh12,
kparichay,
leemgs,
lhs8928,
wooksong,
zhoonit and
a team
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3532. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/. |
GLib-Once (g_once_init_enter/leave) have already taken care of concurrency. Its users do not need to worry about cache coherency or concurrency issues for the initialization. Actually, as nnstreamer#3440 is showing, the volatile keyword is neglected by g_once_init_enter function, making the usage of volatile meaningless anyway. Remove volatile keyword and mitigate the first compiler warning-error of nnstreamer#3440 Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
EREMOTEIO is Linux-specific error code. For the compatibility with non-Linux systems, define it if it's undefined. This partially addresses nnstreamer#3440 Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Disable lua subplugin build if lua is >= 5.3 Reenable Lua >= 5.3 build if nnstreamer#3531 is fixed. Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
The parser code is not comaptible with macos. Reenable after fixing them. This is probably because of parser library versions. Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
myungjoo
force-pushed
the
fix/3440
branch
2 times, most recently
from
be3fa88
to
8eb0398
Compare
jaeyun-jung
approved these changes
Oct 28, 2021
gichan-jang
reviewed
Oct 28, 2021
| @@ -29,6 +29,10 @@ | |||
| #define N_BACKLOG 10 | |||
| #define CLIENT_ID_LEN 4 | |||
|
|
|||
| #ifndef EREMOTEIO | |||
| #define EREMOTEIO 121 /* This is Linux-specific. Define this for non-Linux systems */ | |||
|
@myungjoo Acked:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in macOS 11.2.1, with
$ meson build && ninja -C build.This fixes #3440 (not tested with brew as nnstreamer is no longer available in homebrew: @wooksong could you please re-register it?)
@sebastient Does this fix the issue in your env?