Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNITTEST] Add a skip option to the script running test cases #3534

Merged

Conversation

wooksong
Copy link
Member

This patch adds an option to skip specific test cases to run_unittests_binaries.sh.

Signed-off-by: Wook Song wook16.song@samsung.com

$ ./packaging/run_unittests_binaries.sh -h
run_unittests_binaries.sh: usage: run_unittests_binaries.sh [options] target
    -k | --skip  BINARY_NAME[,*]
        Skip the test cases whose names are...(valid only if target is a directory)

Self evaluation:

  1. Build test: [ ]Passed [ ]Failed [*]Skipped
  2. Run test: [*]Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 28, 2021

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3534. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

This patch adds an option to skip specific test cases to
run_unittests_binaries.sh.

Signed-off-by: Wook Song <wook16.song@samsung.com>
This patch revises file description header comments in the script that
runs unit test binaries as follows:
- Apply the change of the script name
- Use more portable shebang

Signed-off-by: Wook Song <wook16.song@samsung.com>
This patch handles the error case when the target is not given.

Signed-off-by: Wook Song <wook16.song@samsung.com>
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 28, 2021

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3534-202110281425360.98351192474365-2753af3c382d3cecaa2e48eb756a791466f13845/.

@wooksong wooksong force-pushed the add-skiptests-opts/run_unittests_binaries branch from 2753af3 to e5ccc51 Compare October 28, 2021 09:21
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wooksong, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Member

@dongju-chae dongju-chae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myungjoo myungjoo merged commit 5b14a63 into nnstreamer:main Nov 4, 2021
@wooksong wooksong deleted the add-skiptests-opts/run_unittests_binaries branch November 6, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants