Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flatbuf] support flexible tensors #3535

Merged
merged 3 commits into from
Nov 15, 2021
Merged

[Flatbuf] support flexible tensors #3535

merged 3 commits into from
Nov 15, 2021

Conversation

gichan-jang
Copy link
Member

@gichan-jang gichan-jang commented Oct 28, 2021 •
edited

Support flexible tensors for flatbuffers.

Test pipeline
Server:

gst-launch-1.0 \
    videotestsrc pattern=13 ! video/x-raw,format=RGB,width=640,height=480,framerate=5/1 ! tensor_converter ! mux.sink_0 \
    videotestsrc pattern=18 ! video/x-raw,format=RGB,width=640,height=480,framerate=5/1 ! tensor_converter ! other/tensors,format=flexible ! mux.sink_1 \
    tensor_mux name=mux ! tensor_decoder mode=flatbuf ! gdppay ! tcpserversink

Client

gst-launch-1.0 \
    tcpclientsrc ! gdpdepay ! other/flatbuf-tensor ! tensor_converter ! other/tensors,format=flexible ! tensor_sink

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 28, 2021

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3535. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 28, 2021

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3535-202110290046400.40714192390442-e3f51c7d91b8ed797c9046af0a0f7a9b01748f30/.

taos-ci
taos-ci approved these changes Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

taos-ci
taos-ci approved these changes Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@gichan-jang
[Decoder] Support flexible tensors for flatbuf decoder
d5d7faf 
Support flexible tensors for flatbuf decoder.

Signed-off-by: gichan <gichan2.jang@samsung.com>
@gichan-jang
[Converter] Support flextensor for flatbuf converter
a90507c 
Support flextensor for flatbuf converter.

Signed-off-by: gichan <gichan2.jang@samsung.com>
@gichan-jang
[TEST] Add flatbuf for flexible tensors
90bb4e3 
Add flatbuf test for flexible tensors.

Signed-off-by: gichan <gichan2.jang@samsung.com>
taos-ci
taos-ci approved these changes Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

dongju-chae
dongju-chae reviewed Nov 3, 2021
View reviewed changes
tests/nnstreamer_flatbuf/runTest.sh
t. ! queue ! tensor_decoder mode=flatbuf ! other/flatbuf-tensor ! tensor_converter ! multifilesink location=\"flex_flatb_7_%1d.log\" sync=true" 7 0 0 $PERFORMANCE
callCompareTest flex_raw_7_0.log flex_flatb_7_0.log "7-1" "Flatbuf flex tensors conversion test 7-1" 1 0
callCompareTest flex_raw_7_1.log flex_flatb_7_1.log "7-2" "Flatbuf flex tensors conversion test 7-2" 1 0
callCompareTest flex_raw_7_2.log flex_flatb_7_2.log "7-3" "Flatbuf flex tensors conversion test 7-3" 1 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using the same index? (e.g., xxx_7_1.log == test 7-1)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. There are many other tests in this form, so I will modify it at once in the next PR.

dongju-chae
dongju-chae approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@dongju-chae dongju-chae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myungjoo myungjoo merged commit ce4c653 into nnstreamer:main Nov 15, 2021
@gichan-jang gichan-jang deleted the dec/flext/flatbuf branch November 16, 2021 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@taos-ci taos-ci taos-ci approved these changes

@dongju-chae dongju-chae dongju-chae approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@kimjh12 kimjh12 Awaiting requested review from kimjh12

@kparichay kparichay Awaiting requested review from kparichay

@leemgs leemgs Awaiting requested review from leemgs

@lhs8928 lhs8928 Awaiting requested review from lhs8928

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gichan-jang @taos-ci @jaeyun-jung @dongju-chae @myungjoo