Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Protobuf] Support flextensors for protobuf. #3536

Merged
merged 1 commit into from
Nov 17, 2021
Merged

[Protobuf] Support flextensors for protobuf. #3536

merged 1 commit into from
Nov 17, 2021

Conversation

gichan-jang
Copy link
Member

@gichan-jang gichan-jang commented Oct 29, 2021 •
edited

Support flexible tensors for protobuf.

Test pipeline.
Server:

gst-launch-1.0 \
    videotestsrc pattern=13 ! video/x-raw,format=RGB,width=640,height=480,framerate=5/1 ! tensor_converter ! mux.sink_0 \
    videotestsrc pattern=18 ! video/x-raw,format=RGB,width=640,height=480,framerate=5/1 ! tensor_converter ! other/tensors,format=flexible ! mux.sink_1 \
    tensor_mux name=mux ! tensor_decoder mode=protobuf ! gdppay ! tcpserversink

Client

gst-launch-1.0 \
    tcpclientsrc ! gdpdepay ! other/protobuf-tensor ! tensor_converter ! other/tensors,format=flexible ! tensor_sink

Self evaluation:

  1. Build test: [* ]Passed [ ]Failed [ ]Skipped
  2. Run test: [* ]Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 29, 2021

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3536. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

taos-ci
taos-ci approved these changes Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

taos-ci
taos-ci approved these changes Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@gichan-jang
[Protobuf] Support flextensors for protobuf.
6da278e 
 Support flexible tensors for protobuf.

Signed-off-by: gichan <gichan2.jang@samsung.com>
Signed-off-by: Gichan Jang <gichan2.jang@samsung.com>
@gichan-jang gichan-jang changed the title [After #3535] [Protobuf] Support flextensors for protobuf. [Protobuf] Support flextensors for protobuf. Nov 16, 2021
taos-ci
taos-ci approved these changes Nov 16, 2021
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

myungjoo
myungjoo approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myungjoo myungjoo merged commit 2bedc61 into nnstreamer:main Nov 17, 2021
@gichan-jang gichan-jang deleted the flextensor/protobuf branch November 24, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjoo myungjoo myungjoo approved these changes

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@taos-ci taos-ci taos-ci approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@dongju-chae dongju-chae Awaiting requested review from dongju-chae

@helloahn helloahn Awaiting requested review from helloahn

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@kimjh12 kimjh12 Awaiting requested review from kimjh12

@kparichay kparichay Awaiting requested review from kparichay

@leemgs leemgs Awaiting requested review from leemgs

@lhs8928 lhs8928 Awaiting requested review from lhs8928

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gichan-jang @taos-ci @myungjoo @jaeyun-jung