[Build] Add g_memdup2() support for glib >= 2.68

[jvuillaumier]

Function g_memdup() is deprecated starting from glib 2.68, replaced by g_memdup2() :
" Use g_memdup2() instead, as it accepts a #gsize argument for byte_size, avoiding the possibility of overflow in a #gsize → #guint conversion."
https://docs.gtk.org/glib/func.memdup.html

To keep compatibility with the 2 g_memdupX() variants, option used is to detect glib version from meson script.
Alternative option may be to use in the source code construct like:
`
#ifdef GLIB_CHECK_VERSION(2, 68, 0)

data = g_memdup2(...);

#else

data = g_memdup(...);

#endif
`

Self Evaluation:
SSAT tests: passed

Update to fix build with glib version 2.68 and later

Legacy function:
gpointer g_memdup ( gconstpointer mem, guint byte_size )
is deprecated since version 2.68 and replaced by:
gpointer g_memdup2 ( gconstpointer mem, gsize byte_size )

Difference is byte_size argument type changed from guint to gsize.

Signed-off-by: Julien Vuillaumier julien.vuillaumier@nxp.com

[taos-ci]

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3550. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

[taos-ci]

@jvuillaumier, 💯 All CI checkers are successfully verified. Thanks.

[myungjoo]

We can define a macro

#if GLIB_USE_G_MEMDUP2
#define _g_memdup(data, size) g_memdup2 (data, size)
#else
#define _g_memdup(data, size) g_memdup (data, size)
#endif

in a common header (e.g., nnstreamer_pluigin_api.h).
Let's have minimum #if/#endif in .c/.cc files.

[jvuillaumier]

We can define a macro

#if GLIB_USE_G_MEMDUP2
#define _g_memdup(data, size) g_memdup2 (data, size)
#else
#define _g_memdup(data, size) g_memdup (data, size)
#endif

in a common header (e.g., nnstreamer_pluigin_api.h). Let's have minimum #if/#endif in .c/.cc files.

Changeset updated accordingly:
_g_memdup() macro defined in nnstreamer_util.h
_g_memdup() macro used as a replacement of g_memdup() / g_memdup2()

[jaeyun-jung]

how about using macro in header file or version_compare() in meson

Use glib macro in header

#if GLIB_CHECK_VERSION (2, 68, 0)
#define _g_memdup g_memdup2
#else
#define _g_memdup g_memdup
#endif

or meson.build

if glib_dep.version().version_compare('>= 2.68.0')
  add_project_arguments('-DGLIB_USE_G_MEMDUP2', language: ['c', 'cpp'])
endif

IMO, 1st one is better.

[jvuillaumier]

I am fine with dropping meson.build change and go for GLIB_CHECK_VERSION() check in the header file if all agree with that.

However doing so requires addition of
#include <glib.h>
at the top of the header file so that the macro is guaranteed to be defined.
May not be a bid deal but my understanding is that at the moment .c/.cc files include glib.h explicitly, not indirectly via other header files.

[myungjoo]

The first approach (no changes in meson) looks more beautiful, but we cannot ensure the order of #include statements; the coding-style checks (gst-indent, clang-format, ...) often force to reorder them and having such implicit conditions don't feel right.

Let's proceed with the second approach (adding a few lines in meson.build).

[jvuillaumier]

Patchset updated with suggestion from @jaeyun-jung for option 2 in meson.build:

if glib_dep.version().version_compare('>= 2.68.0') add_project_arguments('-DGLIB_USE_G_MEMDUP2', language: ['c', 'cpp']) endif

[taos-ci]

@jvuillaumier, 💯 All CI checkers are successfully verified. Thanks.

[myungjoo]

LGTM

[taos-ci]

@jvuillaumier, 💯 All CI checkers are successfully verified. Thanks.