[TEST] Disable MQTT Test when broker is not available. #3551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gichan-jang
requested review from
again4you,
anyj0527,
dongju-chae,
helloahn,
jaeyun-jung,
jijoongmoon,
kimjh12,
kparichay,
leemgs,
lhs8928,
myungjoo,
wooksong and
zhoonit
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3551. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/. |
gichan-jang
changed the title
taos-ci
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.
dongju-chae
reviewed
Nov 8, 2021
If the broker is not available, the mqtt element cannot be changed to the playing state. However, harnesses are used in the mqtt test, and errors occur if harnesses cannot be changed to the playing state. So, if there's no broker on the test environment, the test fails. For example, the build on the lunch pad failed. https://launchpadlibrarian.net/566158157/buildlog_ubuntu-bionic-amd64.nnstreamer_2.1.0.0-0~202110290743~ubuntu18.04.1_BUILDING.txt.gz Signed-off-by: Gichan Jang <gichan2.jang@samsung.com> Signed-off-by: gichan <gichan2.jang@samsung.com>
gichan-jang
force-pushed
the
fix/mqtttest
branch
from
4887994
to
03f57f2
Compare
taos-ci
approved these changes
Nov 9, 2021
There was a problem hiding this comment.
@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the broker is not available, the mqtt element cannot be changed to the playing state.
However, harnesses are used in the mqtt test, and errors occur if harnesses cannot be changed to the playing state.
So, if there's no broker on the test environment, the test fails.
For example, the build on the lunch pad failed.
https://launchpadlibrarian.net/566158157/buildlog_ubuntu-bionic-amd64.nnstreamer_2.1.0.0-0~202110290743~ubuntu18.04.1_BUILDING.txt.gz
Signed-off-by: Gichan Jang gichan2.jang@samsung.com
Self evaluation: