Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dec/Sub] Add octet-stream decoder subplugin. @open sesame 12/10 14:24 #3556

Merged
merged 1 commit into from
Dec 13, 2021
Merged

[Dec/Sub] Add octet-stream decoder subplugin. @open sesame 12/10 14:24 #3556

merged 1 commit into from
Dec 13, 2021

Conversation

gichan-jang
Copy link
Member

Decode tensors to octet stream.
If tensor format is flexible, remove the header.

Self evaluation:

  1. Build test: [*]Passed [ ]Failed [ ]Skipped
  2. Run test: [*]Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 8, 2021

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3556. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

jaeyun-jung
jaeyun-jung reviewed Nov 8, 2021
View reviewed changes
jni/Android.mk Outdated Show resolved Hide resolved
taos-ci
taos-ci approved these changes Nov 8, 2021
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@gichan-jang gichan-jang force-pushed the dec/octet branch 2 times, most recently from 2a6b23d to 2534354 Compare November 9, 2021 02:01
taos-ci
taos-ci approved these changes Nov 9, 2021
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@jaeyun-jung jaeyun-jung mentioned this pull request Nov 17, 2021
Closed
@gichan-jang gichan-jang deleted the dec/octet branch December 10, 2021 03:59
@gichan-jang gichan-jang reopened this Dec 10, 2021
@gichan-jang gichan-jang changed the title [Wait for others] [Dec/Sub] Add octet-stream decoder subplugin. [Dec/Sub] Add octet-stream decoder subplugin. Dec 10, 2021
@taos-ci
Copy link
Collaborator

taos-ci commented Dec 10, 2021

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3556-202112101313510.54930901527405-7b762ffef0f424a8a7bd0cfd4aa0fc160e0ccb80/.

@gichan-jang gichan-jang changed the title [Dec/Sub] Add octet-stream decoder subplugin. [Dec/Sub] Add octet-stream decoder subplugin. @open sesame 14:24 Dec 10, 2021
@gichan-jang gichan-jang changed the title [Dec/Sub] Add octet-stream decoder subplugin. @open sesame 14:24 [Dec/Sub] Add octet-stream decoder subplugin. @open sesame 12/10 14:24 Dec 10, 2021
taos-ci
taos-ci approved these changes Dec 10, 2021
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@gichan-jang gichan-jang force-pushed the dec/octet branch 2 times, most recently from 42b58bc to 7f08827 Compare December 13, 2021 00:44
@gichan-jang
[Decoder] Decode tensors to octet stream.
6f9b31f 
Decode tensors to octet stream.
If tensor format is flexible, remove the header.

Signed-off-by: gichan <gichan2.jang@samsung.com>
dongju-chae
dongju-chae approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@dongju-chae dongju-chae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

taos-ci
taos-ci approved these changes Dec 13, 2021
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

anyj0527
anyj0527 approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@anyj0527 anyj0527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔

@myungjoo myungjoo merged commit 682f0b4 into nnstreamer:main Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyj0527 anyj0527 anyj0527 approved these changes

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@taos-ci taos-ci taos-ci approved these changes

@dongju-chae dongju-chae dongju-chae approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@kimjh12 kimjh12 Awaiting requested review from kimjh12

@kparichay kparichay Awaiting requested review from kparichay

@leemgs leemgs Awaiting requested review from leemgs

@lhs8928 lhs8928 Awaiting requested review from lhs8928

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

Assignees
No one assigned
Labels
PR/Ready2Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gichan-jang @taos-ci @anyj0527 @jaeyun-jung @dongju-chae @myungjoo