Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: enhancing log behaviors for unittest #3571

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Test: enhancing log behaviors for unittest #3571

merged 1 commit into from
Dec 9, 2021

Conversation

myungjoo
Copy link
Member

@myungjoo myungjoo commented Nov 19, 2021 •
edited 

1. Add a dlog_print hijacker that makes dlog calls independent
from dlog daemon and drivers. As a result, developers can now
read the dlog log messages of unittests in gbs environment.

2. Clean up a bit of meson.build dependency declaration of
unit tests.

3. A unit test without direct dlog call is updated to call
it directly so that the hijacker is linked (edgetpu).

Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 19, 2021

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3571. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 19, 2021

:octocat: cibot: @myungjoo, apptest could not be completed. To find out the reasons, please go to http://nnstreamer.mooo.com//nnstreamer/ci/repo-workers/pr-checker/3571-202111191458520.83496809005737-20dd048cac0dd22964da9fdd078cbcd3c1bd6eb3

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 19, 2021

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3571-202111191458520.83496809005737-20dd048cac0dd22964da9fdd078cbcd3c1bd6eb3/.

@myungjoo myungjoo marked this pull request as ready for review November 22, 2021 08:19
@myungjoo myungjoo changed the title WIP: enhancing log behaviors for unittest Test: enhancing log behaviors for unittest Nov 22, 2021
@taos-ci
Copy link
Collaborator

taos-ci commented Nov 22, 2021

:octocat: cibot: @myungjoo, apptest could not be completed. To find out the reasons, please go to http://nnstreamer.mooo.com//nnstreamer/ci/repo-workers/pr-checker/3571-202111221719260.031795024871826-e1edf9c4feba6188ee083dfa3d90e2f6b0bf7afb

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 22, 2021

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3571-202111221719260.031795024871826-e1edf9c4feba6188ee083dfa3d90e2f6b0bf7afb/.

@myungjoo myungjoo force-pushed the fix/3548 branch 2 times, most recently from 459fcaf to 05d6194 Compare December 6, 2021 04:54
@taos-ci
Copy link
Collaborator

taos-ci commented Dec 6, 2021

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3571-202112061354490.32822895050049-05d61940c48943cd8cbb04f6bd8007a7b02beae3/.

@taos-ci
Copy link
Collaborator

taos-ci commented Dec 6, 2021

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3571-202112061550550.83720803260803-56d8add7081975ae003adabdeca15f85602696ed/.

@taos-ci
Copy link
Collaborator

taos-ci commented Dec 6, 2021

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3571-202112061630080.69458293914795-72a46e35eff81a9f890f68549b82f5462307c166/.

@myungjoo
Test: enhancing log behaviors for unittest
e642457 
1. Add a dlog_print hijacker that makes dlog calls independent
from dlog daemon and drivers. As a result, developers can now
read the dlog log messages of unittests in gbs environment.

2. Clean up a bit of meson.build dependency declaration of
unit tests.

3. A unit test without direct dlog call is updated to call
it directly so that the hijacker is linked (edgetpu).

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
taos-ci
taos-ci approved these changes Dec 7, 2021
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myungjoo, 💯 All CI checkers are successfully verified. Thanks.

again4you
again4you approved these changes Dec 8, 2021
View reviewed changes
Copy link
Collaborator

@again4you again4you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dongju-chae
dongju-chae approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@dongju-chae dongju-chae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

myungjoo added a commit to myungjoo/api that referenced this pull request Dec 9, 2021
@myungjoo
C/common: override dlog infra with stderr for unit testing
446fe03 
With unittesting, especially in GBS, dlog output is
not shown because dlog server is not running.

Replace it with stderr print in unittesting
for better readability in GBS.

This is similar with
nnstreamer/nnstreamer#3571

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
@myungjoo myungjoo mentioned this pull request Dec 9, 2021
Merged
@myungjoo myungjoo merged commit bde6070 into nnstreamer:main Dec 9, 2021
myungjoo added a commit to myungjoo/api that referenced this pull request Dec 9, 2021
@myungjoo
C/common: override dlog infra with stderr for unit testing
1a25f87 
With unittesting, especially in GBS, dlog output is
not shown because dlog server is not running.

Replace it with stderr print in unittesting
for better readability in GBS.

This is similar with
nnstreamer/nnstreamer#3571

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
myungjoo added a commit to myungjoo/api that referenced this pull request Dec 9, 2021
@myungjoo
C/common: override dlog infra with stderr for unit testing
9093566 
With unittesting, especially in GBS, dlog output is
not shown because dlog server is not running.

Replace it with stderr print in unittesting
for better readability in GBS.

This is similar with
nnstreamer/nnstreamer#3571

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
jaeyun-jung pushed a commit to nnstreamer/api that referenced this pull request Dec 10, 2021
@myungjoo @jaeyun-jung
C/common: override dlog infra with stderr for unit testing
b667c69 
With unittesting, especially in GBS, dlog output is
not shown because dlog server is not running.

Replace it with stderr print in unittesting
for better readability in GBS.

This is similar with
nnstreamer/nnstreamer#3571

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
@myungjoo myungjoo mentioned this pull request Mar 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@again4you again4you again4you approved these changes

@taos-ci taos-ci taos-ci approved these changes

@dongju-chae dongju-chae dongju-chae approved these changes

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@kimjh12 kimjh12 Awaiting requested review from kimjh12

@kparichay kparichay Awaiting requested review from kparichay

@leemgs leemgs Awaiting requested review from leemgs

@lhs8928 lhs8928 Awaiting requested review from lhs8928

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@myungjoo @taos-ci @again4you @dongju-chae