multilib correction - #3554 follow up #3582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use 'libdir' for library path to cover a multilib envoironment. These checks are usually done before release, for example in the scenario where images are created for a 64-bit target (imx8 * boards) but which also supports running 32-bit applications. This is the error in a linux/yocto build: | ERROR: nnstreamer-2.0.0-r0 do_package: QA Issue: nnstreamer: Files/directories were installed but not shipped in any package: | /usr/lib/nnstreamer/customfilters/libnnstreamer_customfilter_passthrough_variable.so | /usr/lib/nnstreamer/customfilters/libdummyLSTM.so | /usr/lib/nnstreamer/customfilters/libnnstreamer_customfilter_scaler.so | /usr/lib/nnstreamer/customfilters/libnnstreamer_customfilter_average.so | /usr/lib/nnstreamer/customfilters/libnnstreamer_customfilter_scaler_allocator.so | /usr/lib/nnstreamer/customfilters/libnnscustom_drop_buffer.so | /usr/lib/nnstreamer/customfilters/libnnscustom_framecounter.so | /usr/lib/nnstreamer/customfilters/libdummyRNN.so | /usr/lib/nnstreamer/customfilters/libnnstreamer_customfilter_passthrough.so | /usr/lib/nnstreamer/converters/libnnstreamer_converter_protobuf.so | /usr/lib/nnstreamer/converters/libnnstreamer_converter_python3.so | /usr/lib/nnstreamer/decoders/libnnstreamer_decoder_bounding_boxes.so | /usr/lib/nnstreamer/decoders/libnnstreamer_decoder_direct_video.so | /usr/lib/nnstreamer/decoders/libnnstreamer_decoder_pose_estimation.so | /usr/lib/nnstreamer/decoders/libnnstreamer_decoder_image_labeling.so | /usr/lib/nnstreamer/decoders/libnnstreamer_decoder_image_segment.so | /usr/lib/nnstreamer/decoders/libnnstreamer_decoder_python3.so | /usr/lib/nnstreamer/decoders/libnnstreamer_decoder_protobuf.so | /usr/lib/nnstreamer/filters/libnnstreamer_filter_cpp.so | /usr/lib/nnstreamer/filters/libnnstreamer_filter_armnn.so | /usr/lib/nnstreamer/filters/libnnstreamer_filter_python3.so | /usr/lib/nnstreamer/filters/libnnstreamer_filter_tensorflow2-lite.so | /usr/lib/nnstreamer/extra/nnstreamer_python3.so | Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install. | nnstreamer: 23 installed and not shipped files. [installed-vs-shipped] Signed-off-by: Cristinel Panfir <cristinel.panfir@nxp.com> Cherry-picked from nnstreamer#3554 Signed-off-by: Julien Vuillaumier <julien.vuillaumier@nxp.com>
The PR nnstreamer#3554 breaks conventional non-multilib builds of x64/aarch64 systems (Tizen/Ubuntu). This fixes this side-effect. Todo: fix Yocto build afterwards. Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com> Cherry-picked from panfir#1 Signed-off-by: Julien Vuillaumier <julien.vuillaumier@nxp.com>
jvuillaumier
requested review from
again4you,
anyj0527,
dongju-chae,
gichan-jang,
helloahn,
jaeyun-jung,
jijoongmoon,
kimjh12,
kparichay,
leemgs,
lhs8928,
myungjoo,
wooksong,
zhoonit and
a team
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3582. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/. |
meson.build:
moved nnstreamer_prefix definition upward, before its first usage.
packaging/nnstreamer.spec:
corrected subplugindir definition to rely on actual %{_prefix} variable
and use the expected %{_prefix}/lib/nnstreamer path.
Signed-off-by: Julien Vuillaumier <julien.vuillaumier@nxp.com>
jvuillaumier
force-pushed
the
dev-multilib-follow-up
branch
from
7bdb44a
to
a340633
Compare
taos-ci
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
@jvuillaumier, 💯 All CI checkers are successfully verified. Thanks.
jaeyun-jung
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Tentative patchset for multilib fix, aggregating:
See also: #3554
Self evaluation:
SSAT test suite passed