Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meson: use version_copmare() @open sesame 12/06 13:15 #3592

Merged
merged 1 commit into from
Dec 7, 2021
Merged

meson: use version_copmare() @open sesame 12/06 13:15 #3592

merged 1 commit into from
Dec 7, 2021

Conversation

myungjoo
Copy link
Member

@myungjoo myungjoo commented Dec 6, 2021

Do not compare version strings with general operators.
Use version_compare() API instead.

Reported by #3591

Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com

@myungjoo
meson: use version_copmare()
a8e38f7 
Do not compare version strings with general operators.
Use version_compare() API instead.

Reported by nnstreamer#3591

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
@taos-ci
Copy link
Collaborator

taos-ci commented Dec 6, 2021

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3592. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

@taos-ci
Copy link
Collaborator

taos-ci commented Dec 6, 2021

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3592-202112061149590.90847706794739-a8e38f7973bfc20759453ef4a9dfa947b4e210c9/.

@myungjoo myungjoo changed the title meson: use version_copmare() meson: use version_copmare() @open sesame 12/06 13:15 Dec 6, 2021
taos-ci
taos-ci approved these changes Dec 6, 2021
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myungjoo, 💯 All CI checkers are successfully verified. Thanks.

anyj0527
anyj0527 approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@anyj0527 anyj0527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@myungjoo myungjoo merged commit 47bcd11 into nnstreamer:main Dec 7, 2021
@myungjoo myungjoo deleted the versioncheck branch January 3, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyj0527 anyj0527 anyj0527 approved these changes

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@taos-ci taos-ci taos-ci approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@dongju-chae dongju-chae Awaiting requested review from dongju-chae

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@kimjh12 kimjh12 Awaiting requested review from kimjh12

@kparichay kparichay Awaiting requested review from kparichay

@leemgs leemgs Awaiting requested review from leemgs

@lhs8928 lhs8928 Awaiting requested review from lhs8928

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@myungjoo @taos-ci @anyj0527 @jaeyun-jung