Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Query] Check whether cap is fixed or not. #3604

Merged
merged 1 commit into from
Dec 16, 2021
Merged

[Query] Check whether cap is fixed or not. #3604

merged 1 commit into from
Dec 16, 2021

Conversation

gichan-jang
Copy link
Member

@gichan-jang gichan-jang commented Dec 13, 2021 •
edited

  • Check whether the cap is fixed or not before setting the cap.

Signed-off-by: gichan gichan2.jang@samsung.com

Self evaluation:

  1. Build test: [*]Passed [ ]Failed [ ]Skipped
  2. Run test: [*] Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link
Collaborator

taos-ci commented Dec 13, 2021

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3604. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

@taos-ci
Copy link
Collaborator

taos-ci commented Dec 13, 2021

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3604-202112131543080.87741708755493-43b8f9b69fe3e6e69e153ea0b57abb2f8233158c/.

@gichan-jang gichan-jang force-pushed the query/fixedCaps branch 2 times, most recently from 10de7f9 to a787d13 Compare December 13, 2021 08:40
@gichan-jang
Copy link
Member Author

Q: Is it necessary to set framerate on srcpad?
src pad caps template is any. plz consider the case if src is audio or other mimetype that does not need framerate.

I changed to print error messages and stop the pipeline when the tensors config is invalid. (e.g., framerate is not set.)

@taos-ci
Copy link
Collaborator

taos-ci commented Dec 13, 2021

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3604-202112131740520.25093197822571-a787d1392acd0285f516839afb27389401fd5896/.

@gichan-jang gichan-jang force-pushed the query/fixedCaps branch 2 times, most recently from 2a031d7 to abad2d9 Compare December 14, 2021 04:28
@gichan-jang
Copy link
Member Author

gichan-jang commented Dec 14, 2021 •
edited

@jaeyun-jung @dongju-chae
The tensors config validation check at the start of query server sink was removed. Even if the cap is not defined at start, the cap is received from the connected element during the negation phase.
So, in this PR, I removed setting framerate at the start of the server sink and changed it to check only if it is fixed before setting the cap on the query client source pad.

Recommend to use gst_tensor_get_type_string() for log message

nns_loge ("Failed to validate tensor info. type: %s. "
        "Please specify tensor type. e.g., type=uint8.",
        GST_STR_NULL (gst_tensor_get_type_string (info->type));

Thanks. Since the validation function is not used in this patch, the changes will be uploaded to another PR.

Well.. this variable seems not to be changed in runtime. Any merit to declare it?

Removed related changes. Thanks.

taos-ci
taos-ci approved these changes Dec 14, 2021
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@gichan-jang
[Query] Check whether cap is fixed or not.
aa69676 
 - Check whether the cap is fixed or not before setting the cap.
 - If the tensor format is not fixed, static is set as default format.
 - Set the framerate of the source to the same as the sink.

Signed-off-by: gichan <gichan2.jang@samsung.com>
@gichan-jang
Copy link
Member Author

plz remove this line so that out_caps can be released.

Updated. Thanks.

dongju-chae
dongju-chae approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@dongju-chae dongju-chae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

taos-ci
taos-ci approved these changes Dec 14, 2021
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@myungjoo myungjoo merged commit 42b797f into nnstreamer:main Dec 16, 2021
@gichan-jang gichan-jang deleted the query/fixedCaps branch December 20, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@taos-ci taos-ci taos-ci approved these changes

@dongju-chae dongju-chae dongju-chae approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@kimjh12 kimjh12 Awaiting requested review from kimjh12

@kparichay kparichay Awaiting requested review from kparichay

@leemgs leemgs Awaiting requested review from leemgs

@lhs8928 lhs8928 Awaiting requested review from lhs8928

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gichan-jang @taos-ci @jaeyun-jung @dongju-chae @myungjoo