Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INI] Add extra configuration file for product support #3607

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

again4you
Copy link
Collaborator

@again4you again4you commented Dec 14, 2021

The product team wants to update the nnstreamer configuration (i.e.
/etc/nnstreamer.ini). However, the partition is Read-Only so it is not
updatable. Because of this reason, they want another nnstreamer
configuration file to meet their request such as product-specific
restricted elements. This patch newly adds the nnstreamer extension ini
file for product support.

Signed-off-by: Sangjung Woo sangjung.woo@samsung.com

Self evaluation:

  1. Build test: [ ]Passed [ ]Failed [*]Skipped
  2. Run test: [ ]Passed [ ]Failed [*]Skipped

New element in nnstreamer.ini

[common]
extra_config_path=/tmp/nns-api-X6XDF1/nns-product.ini	 # Location of product-specific configuration file.

Related issue

@taos-ci
Copy link
Collaborator

taos-ci commented Dec 14, 2021

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3607. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@again4you, 💯 All CI checkers are successfully verified. Thanks.

@again4you again4you force-pushed the devel/product_config_v1 branch 2 times, most recently from 081687f to 9f6cb38 Compare January 4, 2022 02:08
@again4you again4you changed the title [WIP][INI] Add extension ini file for product [INI] Add extension ini file for product Jan 4, 2022
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@again4you, 💯 All CI checkers are successfully verified. Thanks.

@again4you again4you changed the title [INI] Add extension ini file for product [INI] Add extra configuration file for product support Jan 14, 2022
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@again4you, 💯 All CI checkers are successfully verified. Thanks.

nnstreamer.ini.in Outdated Show resolved Hide resolved
The product team wants to update the nnstreamer configuration (i.e.
/etc/nnstreamer.ini). However, the partition is Read-Only so it is not
updatable. Because of this reason, they want another nnstreamer
configuration file to meet their request such as product-specific
allowed elements. This patch newly adds the nnstreamer extra
configuration file for product support.

Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
@taos-ci
Copy link
Collaborator

taos-ci commented Jan 21, 2022

:octocat: cibot: @again4you, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3607-202201211446050.1826388835907-6a85a6016c66d21142c65cba64baaee25c954f1a/.

This patch newly adds the test cases for extra configuration.

Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@again4you, 💯 All CI checkers are successfully verified. Thanks.

@myungjoo myungjoo merged commit 251d5f8 into nnstreamer:main Jan 25, 2022
@again4you again4you deleted the devel/product_config_v1 branch May 22, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants