Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filter] set default fw in common #3634

Merged
merged 1 commit into from
Jan 7, 2022
Merged

[Filter] set default fw in common #3634

merged 1 commit into from
Jan 7, 2022

Conversation

jaeyun-jung
Copy link
Collaborator

Fix mem leak, init default framework in filter-common function.

Signed-off-by: Jaeyun jy1210.jung@samsung.com

@taos-ci
Copy link
Collaborator

taos-ci commented Jan 5, 2022

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3634. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

@jaeyun-jung
[Filter] set default fw in common
7366def 
Fix mem leak, init default framework in filter-common function.

Signed-off-by: Jaeyun <jy1210.jung@samsung.com>
@taos-ci
Copy link
Collaborator

taos-ci commented Jan 5, 2022

:octocat: cibot: @jaeyun-jung, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3634-202201051752110.020809888839722-d29f60aaf68f1ac4cc46a902d5b125ecba9354b5/.

taos-ci
taos-ci approved these changes Jan 5, 2022
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.

gichan-jang
gichan-jang approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@gichan-jang gichan-jang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anyj0527
anyj0527 approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@anyj0527 anyj0527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jaeyun-jung jaeyun-jung merged commit 847f110 into nnstreamer:main Jan 7, 2022
@jaeyun-jung jaeyun-jung deleted the filter-common-prop-leak branch January 7, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyj0527 anyj0527 anyj0527 approved these changes

@taos-ci taos-ci taos-ci approved these changes

@gichan-jang gichan-jang gichan-jang approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@dongju-chae dongju-chae Awaiting requested review from dongju-chae

@helloahn helloahn Awaiting requested review from helloahn

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@kimjh12 kimjh12 Awaiting requested review from kimjh12

@kparichay kparichay Awaiting requested review from kparichay

@leemgs leemgs Awaiting requested review from leemgs

@lhs8928 lhs8928 Awaiting requested review from lhs8928

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jaeyun-jung @taos-ci @anyj0527 @gichan-jang