[Filter] Remove gst dep from single-shot #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gichan-jang
requested review from
again4you,
anyj0527,
dongju-chae,
helloahn,
jaeyun-jung,
jijoongmoon,
kimjh12,
kparichay,
leemgs,
lhs8928,
myungjoo,
wooksong,
zhoonit and
a team
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3652. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/. |
taos-ci
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.
jaeyun-jung
reviewed
Feb 3, 2022
myungjoo
reviewed
Feb 4, 2022
|
Dependency cut confirmed in Tizen: |
taos-ci
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.
gichan-jang
force-pushed
the
remove/GstDep/Single
branch
3 times, most recently
from
1ac4a97
to
607f3dc
Compare
taos-ci
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.
niley7464
reviewed
Feb 21, 2022
- Remove gst dependency from single-shot. - Separate single-shot package from nnstreamer(pipeline) - nnstreamer depends nnstreaner-single package. Signed-off-by: gichan <gichan2.jang@samsung.com>
Remove gst dependency from tensor filter subplugins. - tensorflow, tensorflow-lite, pytorch, nnfw,caffe2 TODO: Other subplugins later. Signed-off-by: gichan <gichan2.jang@samsung.com>
Remove gst dependency from singleshot test Signed-off-by: gichan <gichan2.jang@samsung.com>
- Rename the files related to tensor common functions. renamed: gst/nnstreamer/include/nnstreamer_plugin_api_single.h -> gst/nnstreamer/include/nnstreamer_plugin_api_util.h renamed: gst/nnstreamer/tensor_common.c -> gst/nnstreamer/nnstreamer_plugin_api_impl.c renamed: gst/nnstreamer/tensor_common_single.c -> gst/nnstreamer/nnstreamer_plugin_api_util_impl.c - Remove unnecessary pipeline utils from nnstreamer-internal header. Signed-off-by: gichan <gichan2.jang@samsung.com>
gichan-jang
force-pushed
the
remove/GstDep/Single
branch
from
607f3dc
to
f699b1f
Compare
taos-ci
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self evaluation:
Signed-off-by: gichan gichan2.jang@samsung.com