[Svace] fix svace issues #3659
[Svace] fix svace issues #3659
Conversation
jaeyun-jung
requested review from
a team,
myungjoo,
jijoongmoon,
again4you,
leemgs,
wooksong,
helloahn,
kparichay,
dongju-chae,
gichan-jang,
anyj0527,
zhoonit,
lhs8928 and
kimjh12
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3659. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/. |
There was a problem hiding this comment.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
| @@ -597,6 +597,7 @@ gst_tensor_aggregation_add_data (GHashTable * table, const guint32 key) | |||
| else | |||
| hashkey = key; | |||
| aggr = g_new0 (gst_tensor_aggregation_data_s, 1); | |||
| g_assert (aggr != NULL); | |||
There was a problem hiding this comment.
Don't fix this. Mark this "false positive". I have reported this issue to SE (SVACE maintainer) and it appears that they didn't fix it yet; g_new series are supposed to kill the process if g_new fails.
There was a problem hiding this comment.
Besides, try not to add g_assert in non-test-case codes. Try to make proper error handling code instead.
Fix svace issues - init local variable - check allocation failure case Signed-off-by: Jaeyun <jy1210.jung@samsung.com>
There was a problem hiding this comment.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
Fix svace issues
Signed-off-by: Jaeyun jy1210.jung@samsung.com