Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error - unused param, sign comapre #3667

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Fix build error - unused param, sign comapre #3667

merged 1 commit into from
Feb 21, 2022

Conversation

gichan-jang
Copy link
Member

Fix build error caused by unused param.

  • Ignore auto generated files (flatbuf, protobuf)
    Fix different sign compare

Signed-off-by: gichan gichan2.jang@samsung.com

Self evaluation:

  1. Build test: [ *]Passed [ ]Failed [ ]Skipped
  2. Run test: [ *]Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link
Collaborator

taos-ci commented Feb 21, 2022

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3667. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

@taos-ci
Copy link
Collaborator

taos-ci commented Feb 21, 2022

:octocat: cibot: @gichan-jang, tests/nnstreamer_filter_mvncsdk2/NCSDKTensorFilterTestHelper.hh does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

@gichan-jang
Fix build error - unused param, sign comapre
fcb58a1 
 Fix build error caused by unused param.
  - Ignore auto generated files (flatbuf, protobuf)
 Fix different sign compare

Signed-off-by: gichan <gichan2.jang@samsung.com>
taos-ci
taos-ci approved these changes Feb 21, 2022
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

again4you
again4you approved these changes Feb 21, 2022
View reviewed changes
Copy link
Collaborator

@again4you again4you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@again4you again4you merged commit 5b6bf25 into nnstreamer:main Feb 21, 2022
@gichan-jang gichan-jang deleted the fix/unusedParam branch February 24, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@again4you again4you again4you approved these changes

@anyj0527 anyj0527 anyj0527 approved these changes

@taos-ci taos-ci taos-ci approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@kparichay kparichay Awaiting requested review from kparichay

@dongju-chae dongju-chae Awaiting requested review from dongju-chae

@zhoonit zhoonit Awaiting requested review from zhoonit

@lhs8928 lhs8928 Awaiting requested review from lhs8928

@kimjh12 kimjh12 Awaiting requested review from kimjh12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gichan-jang @taos-ci @again4you @anyj0527