Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[transform] Fix transform_caps in direction GST_PAD_SRC #3670

Merged
merged 4 commits into from
Mar 2, 2022
Merged

[transform] Fix transform_caps in direction GST_PAD_SRC #3670

merged 4 commits into from
Mar 2, 2022

Conversation

anyj0527
Copy link
Member

@anyj0527 anyj0527 commented Feb 22, 2022 •
edited

  • Check null before call g_string_append to remove logs g_string_insert_len: assertion 'len == 0 || val != NULL' failed
  • Since tensor_transform cannot specify the sinkpad's type caps in some modes, let the transform_caps remove the field in that case
  • Add a test to check whether tensor_filter - tensor_transform pipeline can be negotiated with static format, not flexible format.
  • Modify the order of caps_intersect_full in tensor_filter

This resolves #3636

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link
Collaborator

taos-ci commented Feb 22, 2022

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3670. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

@anyj0527 anyj0527 force-pushed the fix-transform-nego branch 2 times, most recently from 10ed65c to dfae362 Compare February 22, 2022 09:40
@anyj0527 anyj0527 mentioned this pull request Feb 22, 2022
Closed
@taos-ci
Copy link
Collaborator

taos-ci commented Feb 22, 2022

:octocat: cibot: @anyj0527, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3670-202202221840120.92935800552368-dfae362a4ed4ff83a460ce8088d34b0bec1f31a7/.

taos-ci
taos-ci approved these changes Feb 24, 2022
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anyj0527, 💯 All CI checkers are successfully verified. Thanks.

wooksong
wooksong approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@wooksong wooksong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

myungjoo
myungjoo approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeyun-jung
Copy link
Collaborator

YJ, plz do rebase to fix conflict.

@anyj0527
[fix/common] Fix calling g_string_append with null
5a100f4 
- Check null before call g_string_append
- This removes the logs `g_string_insert_len: assertion 'len == 0 || val != NULL' failed`

REF: nnstreamer#3666
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
@anyj0527
[transform] Fix transform_caps in direction GST_PAD_SRC
1d1f6df 
- Since tensor_transform cannot specify the sinkpad's type caps in some modes,
  let the `transform_caps` remove the field in that case

Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
@anyj0527
[tests] Add a ssat testcase to check proper negotiation
c8ba7d8 
- Test whether tensor_filter - tensor_transform pipeline can be
  negotiated with static format, not flexible format.

Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
@anyj0527
[tensor_filter] Modify the order of caps_intersect_full
072a634 
- The pipeline reported in nnstreamer#3636 has nego fail issue because the caps is
   fixated with flexible right after tensor_filter.
- To resolve this, change the order of `gst_caps_intersect_full` in transform_caps.
   This makes static format to be chosen.
- This resolves nnstreamer#3636

Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
taos-ci
taos-ci approved these changes Mar 2, 2022
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anyj0527, 💯 All CI checkers are successfully verified. Thanks.

@jaeyun-jung jaeyun-jung merged commit 1ff92a0 into nnstreamer:main Mar 2, 2022
@anyj0527 anyj0527 deleted the fix-transform-nego branch March 2, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjoo myungjoo myungjoo approved these changes

@wooksong wooksong wooksong approved these changes

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@taos-ci taos-ci taos-ci approved these changes

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@leemgs leemgs Awaiting requested review from leemgs

@helloahn helloahn Awaiting requested review from helloahn

@kparichay kparichay Awaiting requested review from kparichay

@dongju-chae dongju-chae Awaiting requested review from dongju-chae

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

@lhs8928 lhs8928 Awaiting requested review from lhs8928

@kimjh12 kimjh12 Awaiting requested review from kimjh12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Negotiation fails for other/tensors but pass for other/tensor in some pipelines.
5 participants
@anyj0527 @taos-ci @jaeyun-jung @myungjoo @wooksong