Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeClean/Python] possible leak in python subbplugin #3685

Merged
merged 1 commit into from
Mar 8, 2022
Merged

[CodeClean/Python] possible leak in python subbplugin #3685

merged 1 commit into from
Mar 8, 2022

Conversation

jaeyun-jung
Copy link
Collaborator

@jaeyun-jung jaeyun-jung commented Mar 7, 2022 •
edited

Code clean,

  1. possible leak and exception to load python module.
  2. remove unnecessary macro.

Signed-off-by: Jaeyun jy1210.jung@samsung.com

@taos-ci
Copy link
Collaborator

taos-ci commented Mar 7, 2022

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3685. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

@jaeyun-jung
Copy link
Collaborator Author

Error

[  263s] Traceback (most recent call last):
[  263s]   File "/usr/lib64/python3.9/site-packages/numpy/__init__.py", line 140, in <module>
[  263s]     from . import core
[  263s]   File "/usr/lib64/python3.9/site-packages/numpy/core/__init__.py", line 48, in <module>
[  263s]     raise ImportError(msg)
[  263s] ImportError: 
[  263s] 
[  263s] IMPORTANT: PLEASE READ THIS FOR ADVICE ON HOW TO SOLVE THIS ISSUE!
[  263s] 
[  263s] Importing the numpy C-extensions failed. This error can happen for
[  263s] many reasons, often due to issues with your setup or how NumPy was
[  263s] installed.
[  263s] 
[  263s] We have compiled some common reasons and troubleshooting tips at:
[  263s] 
[  263s]     https://numpy.org/devdocs/user/troubleshooting-importerror.html
[  263s] 
[  263s] Please note and check the following:
[  263s] 
[  263s]   * The Python version is: Python3.9 from "/bin/python3"
[  263s]   * The NumPy version is: "1.19.4"
[  263s] 
[  263s] and make sure that they are the versions you expect.
[  263s] Please carefully study the documentation linked above for further help.
[  263s] 
[  263s] Original error was: /usr/lib64/python3.9/site-packages/numpy/core/_multiarray_umath.cpython-39-x86_64-linux-gnu.so: undefined symbol: PyObject_SelfIter

@taos-ci
Copy link
Collaborator

taos-ci commented Mar 7, 2022

:octocat: cibot: @jaeyun-jung, apptest could not be completed. To find out the reasons, please go to http://nnstreamer.mooo.com//nnstreamer/ci/repo-workers/pr-checker/3685-202203071805060.70070695877075-d3e55607e5d73557d0692a5ce28e0fe127c5acba

@taos-ci
Copy link
Collaborator

taos-ci commented Mar 7, 2022

:octocat: cibot: @jaeyun-jung, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3685-202203071805060.70070695877075-d3e55607e5d73557d0692a5ce28e0fe127c5acba/.

@jaeyun-jung
[CodeClean/Python] possible leak in python subbplugin
546dc4a 
Code clean,
1. possible leak and exception to load python module.
2. remove unnecessary macro.

Signed-off-by: Jaeyun <jy1210.jung@samsung.com>
@jaeyun-jung jaeyun-jung changed the title [Subplugin/Python] init numpy in python subplugin [CodeClean/Python] possible leak in python subbplugin Mar 7, 2022
taos-ci
taos-ci approved these changes Mar 7, 2022
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.

anyj0527
anyj0527 approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@anyj0527 anyj0527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mem-leak is gone! LGTM👍

gichan-jang
gichan-jang approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@gichan-jang gichan-jang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeyun-jung jaeyun-jung merged commit 705f6e9 into nnstreamer:main Mar 8, 2022
@myungjoo myungjoo mentioned this pull request Mar 8, 2022
Closed
@jaeyun-jung jaeyun-jung deleted the test-python-sub branch March 8, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyj0527 anyj0527 anyj0527 approved these changes

@taos-ci taos-ci taos-ci approved these changes

@gichan-jang gichan-jang gichan-jang approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@leemgs leemgs Awaiting requested review from leemgs

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@kparichay kparichay Awaiting requested review from kparichay

@dongju-chae dongju-chae Awaiting requested review from dongju-chae

@zhoonit zhoonit Awaiting requested review from zhoonit

@lhs8928 lhs8928 Awaiting requested review from lhs8928

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jaeyun-jung @taos-ci @anyj0527 @gichan-jang