Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lts][for tizen 6.5] Hot fix for snpe filter and release 2.0.1 lts #3702

Merged
merged 6 commits into from
Mar 29, 2022
Merged

[lts][for tizen 6.5] Hot fix for snpe filter and release 2.0.1 lts #3702

merged 6 commits into from
Mar 29, 2022

Conversation

anyj0527
Copy link
Member

@anyj0527 anyj0527 commented Mar 29, 2022 •
edited

  • Inference with certain models got segfault with current implementation.
  • Apply recent commits related with snpe filter to lts/2.0.y branch
  • This will fix the bug and optimize performance in target board

And releases 2.0.1 lts, which fixes bugs and build issues after 2.0.0.
This release includes:

  • Fix critical bugs in destructor of cpp class sup-plugin
  • Add "user buffer" mode in snpe filter, which removes memcpy and resolves segfault issues in some models.
  • Fix MQTT related test failure issues.
  • Fix other build issues.

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@anyj0527
[filter/snpe] Support uint8 input/output type
43a994d 
- If custom prop "InputType:uint8,OutputType:uint8" is given,
  run the model as uint8 input/output type mode.

Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
@anyj0527
[test/snpe] Add snpe unittest for uint8 input/output model
e583e50 
- Add a snpe model `add2_uint8.dlc` which takes
  a single uint8 value as input.
- Add a unittest with it.

Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
@anyj0527
[fix/filter] Add check for model file in some filters
16b4a2d 
- Add check for `G_FILE_TEST_IS_REGULAR` in some cpp class based filters

Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
@anyj0527
[filter/snpe] Support "user supplied buffer" for snpe
430e65c 
- Support "userbuffer" for snpe filter
- With this mode, the memcpy from/into model's input/output does not occur
- Note that it only supports float type

Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
@anyj0527
[test/snpe] Add unittest for snpe filter's user buffer mode
c572a14 
- Add two simple cases to test user buffer execution

Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
@taos-ci
Copy link
Collaborator

taos-ci commented Mar 29, 2022

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3702. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

@myungjoo
Copy link
Member

After fixing up the errors, please add a commit updating the version from 2.0.0 to 2.0.1

@anyj0527
Release of 2.0.1 LTS
0a4cba1 
This releases 2.0.1 lts, which fixes bugs and build issues after 2.0.0.

This release includes:
- Fix critical bugs in destructor of cpp class sup-plugin
- Add "user buffer" mode in snpe filter, which removes memcpy and resolves segfault issues in some models.
- Fix MQTT related test failure issues.
- Fix other build issues.

Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
@anyj0527 anyj0527 changed the title [lts][for tizen 6.5] Hot fix for snpe filter [lts][for tizen 6.5] Hot fix for snpe filter and release 2.0.1 lts Mar 29, 2022
@again4you
Copy link
Collaborator

Because our CI infra is based on the latest Tizen (v 7.0), this PR is failed to build the rpm package.
However, I tested both the tizen 6.5 configuration and DA Robot configuration and they are OK.

@taos-ci
Copy link
Collaborator

taos-ci commented Mar 29, 2022

:octocat: cibot: @anyj0527, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3702-202203291713040.26833510398865-0a4cba1966871dbf6925ae6fbb332df585a274e9/.

myungjoo
myungjoo approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myungjoo myungjoo merged commit 8409468 into nnstreamer:lts/2.0.y Mar 29, 2022
@anyj0527 anyj0527 deleted the lts/6.5/snpe-userbuffer branch April 15, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@again4you again4you again4you approved these changes

@myungjoo myungjoo myungjoo approved these changes

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn helloahn is a code owner

@kparichay kparichay Awaiting requested review from kparichay kparichay is a code owner

@dongju-chae dongju-chae Awaiting requested review from dongju-chae dongju-chae is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit zhoonit is a code owner

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anyj0527 @taos-ci @myungjoo @again4you