Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeClean] fix svace issue #3715

Merged
merged 1 commit into from
Apr 8, 2022
Merged

[CodeClean] fix svace issue #3715

merged 1 commit into from
Apr 8, 2022

Conversation

jaeyun-jung
Copy link
Collaborator

@jaeyun-jung jaeyun-jung commented Apr 8, 2022

  1. Set interpreter lock while replacing interpreter in tf-lite sub-plugin.
  2. Remove unreached code in converter.
  3. Clearly check file ext (bmp) in test util.

Signed-off-by: Jaeyun jy1210.jung@samsung.com

@taos-ci
Copy link
Collaborator

taos-ci commented Apr 8, 2022

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3715. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.

1. Set interpreter lock while replacing interpreter in tf-lite sub-plugin.
2. Remove unreached code in converter.
3. Clearly check file ext (bmp) in test util.

Signed-off-by: Jaeyun <jy1210.jung@samsung.com>
Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Collaborator

@again4you again4you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@again4you again4you merged commit 9212758 into nnstreamer:main Apr 8, 2022
@jaeyun-jung jaeyun-jung deleted the fix-svace-issue branch April 8, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants