[Filter] unnecessary initialization #3720
Conversation
jaeyun-jung
requested review from
a team,
myungjoo,
jijoongmoon,
again4you,
leemgs,
wooksong,
helloahn,
kparichay,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu and
niley7464
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3720. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/. |
There was a problem hiding this comment.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
|
Is this ok with the usage in If it's not ok, for the optimization you've mentioned, we may add a init-check member in GstTensorFilterFrameworkInit. |
Remove unnecessary init while parsing accel string. - fetch fw info to parse accel for the case if nn framework is not opened. - check fw info if open() callback of nn framework is not written. Signed-off-by: Jaeyun <jy1210.jung@samsung.com>
|
To reviewers, 2022-04-14 PR updated. Please review the changes again.
|
There was a problem hiding this comment.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
Remove unnecessary init while parsing accel string.
Signed-off-by: Jaeyun jy1210.jung@samsung.com