Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memleak fix: converter test case fix #4227

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

myungjoo
Copy link
Member

@myungjoo myungjoo commented Aug 30, 2023

converter gtest code mem leak.

converter element mem leak fix is coming with another PR that fixes multiple elements: #4238

@taos-ci
Copy link
Collaborator

taos-ci commented Aug 30, 2023

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #4227. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myungjoo, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Contributor

@songgot songgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

converter gtest code mem leak by not calling gst_object_unref

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
@myungjoo myungjoo changed the title [WIP] memleak fix: converter fix memleak fix: converter test case fix Sep 6, 2023
@myungjoo myungjoo marked this pull request as ready for review September 6, 2023 08:13
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myungjoo, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Member

@anyj0527 anyj0527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeyun-jung jaeyun-jung merged commit 8615acd into nnstreamer:main Sep 6, 2023
34 checks passed
@myungjoo myungjoo deleted the fix/test/converter branch January 3, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants