Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactoring] Split bounding_box struct #4427

Merged
merged 4 commits into from
May 16, 2024
Merged

[Refactoring] Split bounding_box struct #4427

merged 4 commits into from
May 16, 2024

Commits on May 14, 2024

  1. [Refactoring] Split bounding_box struct 

    This patch splites properties so that bounding_box struct
does not have properties for all cases.
Also some functions like bb_setOptions, bb_decode have too many if cases,
so I replaced it to use pure virtual functions.

Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
    @niley7464
    niley7464 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    fb959cd View commit details
    Browse the repository at this point in the history

  2. [CodeClean] Change macro to subclass variable, use enum class 

    This patch changes macro to subclass static-const variable.
Also use enum class instead of unclear integer code.

Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
    @niley7464
    niley7464 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    a14fb46 View commit details
    Browse the repository at this point in the history

  3. [decoder] Remove subclasses in the header 

    This patch removes subclasses in the tensordec-boundingbox header.
Each box properties are located inside box_properties subdir.

Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
    @niley7464
    niley7464 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8718270 View commit details
    Browse the repository at this point in the history

  4. [decoder] Remove dependency from base class to derived class 

    This patch removes dependency from Bounding box class to properties.
setBoxDecodingMode does not need to be modified even if a new box property added.

Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
    @niley7464
    niley7464 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    49be3ba View commit details
    Browse the repository at this point in the history