[filter] Support snpe filter in android #4487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyj0527
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
wooksong,
gichan-jang,
songgot,
jihochu,
niley7464,
yeonykim2 and
a team
as code owners
- Let `custom=Runtime:[CPU|GPU|DSP|NPU]` set each snpe runtime. Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
- Support snpe (SDK v2) in Android. Some additional env variables are requires to be set. REF: https://docs.qualcomm.com/bundle/publicresource/topics/80-63442-2/dsp_runtime.html Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
anyj0527
force-pushed
the
snpe2-support-android
branch
from
a65c156
to
250a833
Compare
- Determine proper source code out of `tensor_filter_snpe.cc` and `tensor_filter_snpe_v1.cc` Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
wooksong
approved these changes
Jun 13, 2024
myungjoo
reviewed
Jun 14, 2024
| ifeq ($(shell test -d ${SNPE_ROOT}/include/zdl; echo $$?),0) | ||
| NNSTREAMER_FILTER_SNPE_SRCS := \ | ||
| $(NNSTREAMER_EXT_HOME)/tensor_filter/tensor_filter_snpe_v1.cc | ||
| endif |
There was a problem hiding this comment.
Isn't this too dangerous assumption?
I'd recommend:
- build snpe(v2) if v2 is available
- build snpe(v1) if v1 is available AND v2 is not available.
The current logic is
- build snpe(v2) if v2 is available AND v1 is NOT available
- build snpe(v1) if v1 is available AND.
There was a problem hiding this comment.
I assume $SNPE_ROOT is unique and a single SNPE SDK does not have both header directories for V1 and V2. I think there is no possibility to both v1 and v2 available.
There was a problem hiding this comment.
ok.. if !exist(zdl) means !v2, let's proceed.
myungjoo
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional env variables are requires to be set.
REF: https://docs.qualcomm.com/bundle/publicresource/topics/80-63442-2/dsp_runtime.html
Self evaluation: