Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TensorRT 10. #4489

Merged

Conversation

bveldhoen
Copy link
Contributor

Added a separate subplugin for tensorrt 10.

Changes proposed in this PR:

  • Using onnx parser.
  • Add support for tensorrt 10.

See also:
nnstreamer/nnstreamer-example#338

Self evaluation:

  • Build test: [ ]Passed [ ]Failed [*]Skipped
  • Run test: [ ]Passed [ ]Failed [*]Skipped

How to evaluate:

  • Run the example in the nnstreamer-example.

@@ -17,7 +17,9 @@ option('orcc-support', type: 'feature', value: 'auto')
option('snpe-support', type: 'feature', value: 'auto')
option('protobuf-support', type: 'feature', value: 'auto')
option('flatbuf-support', type: 'feature', value: 'auto')
option('cuda-support', type: 'feature', value: 'auto')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need cuda-support configured by users.

if not get_option('cuda-support').disabled()

can be rewritten as

if not get_option('tensorrt-support').disabled() or not get_option('tensorrt10-support').disabled()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. (nitpick: this will require any subsequent filter that requires cuda to be added to this condition.)

@myungjoo
Copy link
Member

To pass the "Doxygen tag check" of "Static checkers and verifiers", add a Doxygen (@brief) description for a new structure declaration at:

Error:  File name: ext/nnstreamer/tensor_filter/tensor_filter_tensorrt10.cc, 86 line, structure needs @brief tag 
Error:  File name: ext/nnstreamer/tensor_filter/tensor_filter_tensorrt10.cc, 103 line, structure needs @brief tag

@bveldhoen bveldhoen force-pushed the feature/add_tensor_filter_tensorrt10 branch 2 times, most recently from 3f5563e to 194c700 Compare June 20, 2024 13:32
tools/cuda-version.sh Outdated Show resolved Hide resolved
Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please add a newline at the end of a text file (cuda-version.sh).

@bveldhoen bveldhoen force-pushed the feature/add_tensor_filter_tensorrt10 branch from 194c700 to 8c14bb0 Compare June 21, 2024 07:47
Adds a tensor_filter (tensorrt10) for TensorRT 10+ using the onnx and
engine parsers. Leaves as-is the tensor_filter (tensorrt) for TensorRT
10- using the uffparsers.

Signed-off-by: Bram Veldhoen <noreply@github.com>
@bveldhoen bveldhoen force-pushed the feature/add_tensor_filter_tensorrt10 branch from 8c14bb0 to 28c42ec Compare June 21, 2024 11:04
@myungjoo myungjoo merged commit 66234fd into nnstreamer:main Jun 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants