[Query] case when change pipe state #4491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set caps in edge handle before calling change-state callback. Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
jaeyun-jung
requested review from
myungjoo,
jijoongmoon,
again4you,
wooksong,
gichan-jang,
anyj0527,
songgot,
jihochu,
niley7464,
yeonykim2 and
a team
as code owners
djeong20
reviewed
Jun 20, 2024
Comment on lines
206
to
210
| case GST_STATE_CHANGE_PLAYING_TO_PAUSED: | ||
| gst_tensor_query_server_release_edge_handle (sink->sink_id); | ||
| break; | ||
| case GST_STATE_CHANGE_PAUSED_TO_PLAYING: | ||
| caps = gst_pad_peer_query_caps (GST_BASE_SINK_PAD (bsink), NULL); | ||
| gst_tensor_query_serversink_set_caps(bsink, caps); | ||
| break; | ||
| default: | ||
| break; |
There was a problem hiding this comment.
It seems like now the switch statement has only one case. maybe it can use an if statement?
if (transition == GST_STATE_CHANGE_PLAYING_TO_PAUSED) {
gst_tensor_query_server_release_edge_handle (sink->sink_id);
}
There was a problem hiding this comment.
possible, however for future work, use switch-case (guide from gst sample, I am not sure but if adding another state change is required later, better remaining current code.)
anyj0527
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set caps in edge handle before calling change-state callback.