Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Use c++17 for ndk-build #4495

Merged
merged 2 commits into from
Jun 25, 2024
Merged

[Android] Use c++17 for ndk-build #4495

merged 2 commits into from
Jun 25, 2024

Conversation

niley7464
Copy link
Contributor

This patch changes the c++ version to 17 in the jni files. meson.build also uses cpp_std=c++17.
#4493

Self evaluation:

  1. Build test: []Passed [ ]Failed []Skipped
  2. Run test: [ ]Passed [ ]Failed [*]Skipped

@myungjoo
Copy link
Member

NDK r12b appears not compatible with the option -std=c++17. You may need to update the NDK version requirement, too.
You will need to update https://github.com/nnstreamer/nnstreamer/blob/main/jni/README.md and the Android github-action workflow.

@wooksong
Copy link
Member

How about overriding it from the nnstreamer-android build script?

@niley7464
[Android] Use c++17 for ndk-build
edb55f3 
This patch changes the c++ version to 17 in the jni files.

Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
@niley7464
[action] Use r25c for c++17 in Android build action
fce1875 
This patch changes ndk-version in github action to use c++17 in Android.

Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
anyj0527
anyj0527 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@anyj0527 anyj0527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@jaeyun-jung jaeyun-jung merged commit a9bb5cd into nnstreamer:main Jun 25, 2024
15 checks passed
@niley7464 niley7464 deleted the android/c++17 branch June 25, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjoo myungjoo myungjoo approved these changes

@anyj0527 anyj0527 anyj0527 approved these changes

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@yeonykim2 yeonykim2 Awaiting requested review from yeonykim2 yeonykim2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@niley7464 @myungjoo @wooksong @anyj0527 @jaeyun-jung