-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Initial implementation of executorch tensor filter #4497
Open
leeeryboy
wants to merge
7
commits into
nnstreamer:main
Choose a base branch
from
jinotter3:executorch-draft
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@leeeryboy This looks as a good start of supporting ExecuTorch, great Thanks! |
Signed-off-by: Junhyeong Kim <leeeryboy@gmail.com>
Signed-off-by: Junhyeong Kim <leeeryboy@gmail.com>
Signed-off-by: Junhyeong Kim <leeeryboy@gmail.com>
Signed-off-by: Junhyeong Kim <leeeryboy@gmail.com>
Signed-off-by: Junhyeong Kim <leeeryboy@gmail.com>
Signed-off-by: Junhyeong Kim <leeeryboy@gmail.com>
Signed-off-by: Junhyeong Kim <leeeryboy@gmail.com>
1ba0834
to
5e2dee7
Compare
anyj0527
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
I tested/verified this locally. Great thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future Work and Implementation
This draft pull request lays the groundwork for integrating the executorch tensor filter into nnstreamer. Although the current implementation is not yet complete and might have some errors or inefficiencies, we believe it can serve as a valuable starting point and reference for future work on this feature.
Build and Performance Considerations
During the development of this draft PR, we encountered significant performance issues with the current stable branch of executorch (v0.2.1). Despite our efforts to investigate and resolve these issues, we were unable to identify the root cause of the performance degradation.
As a result, we made the decision to build the executorch main branch instead of the stable v0.2.1 branch. While we acknowledge that using the main branch may introduce instability and potential compatibility issues, we found that it provided better performance compared to the stable branch.
Building ExecuTorch:
Integrating ExecuTorch to NNStreamer:
(NEED FUTURE IMPROVEMENT: We could not find out a nice way to register kernels when using executorch runtime in nnstreamer)
ref. https://github.com/nnstreamer/nnstreamer/blob/main/Documentation/getting-started-meson-build.md
Self evaluation:
Example Image classfication test script: