Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -Denable-fp16=true build to CI #2560

Closed
heka1024 opened this issue Apr 29, 2024 · 6 comments · Fixed by #2641
Closed

Add -Denable-fp16=true build to CI #2560

heka1024 opened this issue Apr 29, 2024 · 6 comments · Fixed by #2641
Assignees
@heka1024

Comments

@heka1024
Copy link
Contributor

Some code could break build with -Denable-fp16=true option, like #2545. I think it would be helpful to add this build to CI to ease the burden on reviewers.
@taos-ci
Copy link
Collaborator

taos-ci commented Apr 29, 2024

:octocat: cibot: Thank you for posting issue #2560. The person in charge will reply soon.

@heka1024
Copy link
Contributor Author

@skykongkong8 What do you think?

@heka1024 heka1024 mentioned this issue Apr 29, 2024
Merged
@skykongkong8
Copy link
Member

skykongkong8 commented Apr 29, 2024 •
edited
Loading

Good point.
As far as I am concerned, Reason why -Denable-fp16 is not included in current CI is because it is relatively newer option than the others.
Even for now, I personally think that it is not really matured to be checked for every PR, because we have multiple plans to refactorize the structure of half-precision formats or related codes.. I need more opinions about this. @jijoongmoon

@myungjoo
Copy link
Member

myungjoo commented Apr 29, 2024 •
edited
Loading

You may add enable-fp16 build test in CI.
You may limit test coverage or error reporting mechanisms for enable-fp16, too. (you can let github-action gracefully ignore failed TCs, too, so that we can see the number of failed cases but the CI says "OK".)

Anyone needing this may add it. (@heka1024 ?)

@heka1024
Copy link
Contributor Author

heka1024 commented Apr 29, 2024 •
edited
Loading

@skykongkong8 @myungjoo I'll add this to CI. (As non-required test) Thanks for comment!

@skykongkong8
Copy link
Member

Great! Thanks for pointing this issue out :)

heka1024 added a commit to heka1024/nntrainer that referenced this issue Jun 17, 2024
@heka1024
[CI] Add fp-16 build in github action
20458b5 
Closes nnstreamer#2560. You can now see the build results from Fp16 in a Github action.

**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: heka1024 <heka1024@gmail.com>
@heka1024 heka1024 mentioned this issue Jun 17, 2024
Merged
heka1024 added a commit to heka1024/nntrainer that referenced this issue Jun 18, 2024
@heka1024
[CI] Add fp-16 build in github action
ddef03c 
Closes nnstreamer#2560. You can now see the build results from Fp16 in a Github action.

**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: heka1024 <heka1024@gmail.com>
@heka1024 heka1024 mentioned this issue Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heka1024 heka1024

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI] Add fp-16 build in github action heka1024/nntrainer
4 participants
@myungjoo @taos-ci @heka1024 @skykongkong8