Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Layer] Add missing activation type #2665

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

SeoHyungjun
Copy link
Member

Some activation types were missing from EnumList.
Added missing types to EnumList.

Changed the order of ActivationType and EnumList to be the same.

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: SeoHyungjun hyungjun.seo@samsung.com

@taos-ci
Copy link
Collaborator

taos-ci commented Jul 3, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2665. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SeoHyungjun, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Contributor

@baek2sm baek2sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM

Copy link
Contributor

@lhs8928 lhs8928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Catch !!! LGTM!

Copy link
Contributor

@djeong20 djeong20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@EunjuYang EunjuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myungjoo
Copy link
Member

myungjoo commented Jul 6, 2024

#2658 is already merged. rebase this.

@skykongkong8
Copy link
Member

skykongkong8 commented Jul 8, 2024

FYI) #2658 is from another branch tanh_gelu on upstream.

Some activation types were missing from EnumList.
Added missing types to EnumList.

Changed the order of ActivationType and EnumList to be the same.

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: SeoHyungjun <hyungjun.seo@samsung.com>
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SeoHyungjun, 💯 All CI checkers are successfully verified. Thanks.

@SeoHyungjun SeoHyungjun changed the title [Wait for #2658][Layer] Add missing activation type [Layer] Add missing activation type Jul 18, 2024
@SeoHyungjun
Copy link
Member Author

#2658 is already merged. rebase this.

I have completed the rebase.

@SeoHyungjun
Copy link
Member Author

FYI) #2658 is from another branch tanh_gelu on upstream.

Yes, that's right.
#2658 has been merged into the main so there is no problem.

@jijoongmoon jijoongmoon merged commit f8c5842 into nnstreamer:main Jul 18, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants