Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DataBufferFromDataFile Class #50

Merged
merged 1 commit into from Apr 22, 2020

Conversation

jijoongmoon
Copy link
Collaborator

In order to handle various input generation cases, make DataBuffer
Class is base class and inherit this, several children classes is
introduced.
. DataBufferFromDataFile
. DataBufferFromCallback : NYI
. DataBufferFromFramework : NYI
. others. : NYI

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: jijoong.moon jijoong.moon@samsung.com

@taos-ci
Copy link
Collaborator

taos-ci commented Apr 21, 2020

📝 TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #50. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ec2-54-180-96-14.ap-northeast-2.compute.amazonaws.com/.

@taos-ci
Copy link
Collaborator

taos-ci commented Apr 21, 2020

:octocat: cibot: @jijoongmoon, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ec2-54-180-96-14.ap-northeast-2.compute.amazonaws.com/nntrainer/ci/repo-workers/pr-checker/50-202004212032240.22357988357544-ab2feb58284b6be95487ce3eee9596fa51f3b417/.

@zhoonit
Copy link
Contributor

zhoonit commented Apr 22, 2020

How about making a class-bound function(classmethods in java, python, static member function in c++??) to initiate DataBuffer buffer instead of inheriting data buffer by source of databuffer?

If initiating part is going to be lengthy, I think a factory can be used instead for this purpose.

eg.

  DataBuffer dataBufferFromFile = DataBuffer::fromFile('some file path.dat') 
  DataBuffer dataBufferFromFramework = DataBuffer::fromFramework('some framework??')

@jijoongmoon
Copy link
Collaborator Author

I think the DataBuffer class would be too long if it is member function. Also there is possibility to add more DataBuffer ( may be nnstreamer pipe line buffer )

How about making a class-bound function(classmethods in java, python, static member function in c++??) to initiate DataBuffer buffer instead of inheriting data buffer by source of databuffer?

In order to handle various input generation cases, make DataBuffer
Class is base class and inherit this, several children classes is
introduced.
. DataBufferFromDataFile
. DataBufferFromCallback : NYI
. DataBufferFromFramework : NYI
. others. : NYI

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: jijoong.moon <jijoong.moon@samsung.com>
Copy link
Contributor

@zhoonit zhoonit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ;)

@jijoongmoon jijoongmoon merged commit 1b50564 into nnstreamer:master Apr 22, 2020
@jijoongmoon jijoongmoon deleted the rawdatabuffer branch April 12, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants