[ccapi] Syntactic sugar constructors #735
Conversation
kparichay
requested review from
again4you,
anyj0527,
dongju-chae,
gichan-jang,
helloahn,
jaeyun-jung,
jijoongmoon,
leemgs,
myungjoo,
wooksong,
zhoonit and
a team
as code owners
|
📝 TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #735. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/. |
|
@zhoonit My apologies, but can you please review once more. Direct methods are added for layers and loss as well. |
| return layer; | ||
| } | ||
|
|
||
| namespace loss { |
There was a problem hiding this comment.
Are we gonna open up loss layer? I think our code is not ready for this.
There was a problem hiding this comment.
How about we have an alias sth like using Loss = Layer?
There was a problem hiding this comment.
The loss_layer was already opened. However, there was no way to choose the loss type for the created loss layer.
This patch allows that.
Handling adding loss layer externally, I am handling that now in a separate PR.
There was a problem hiding this comment.
How about we have an alias sth like using Loss = Layer?
creating two namespace purpose is to keep loss and layer decoupled. If later, loss is removed a layer, it would require updates here.
kparichay
changed the title
kparichay
force-pushed
the
cpp_syntactic_sugar
branch
from
2504f29
to
35abe5e
Compare
kparichay
changed the title
kparichay
force-pushed
the
cpp_syntactic_sugar
branch
from
35abe5e
to
897b36d
Compare
kparichay
changed the title
test/ccapi/unittest_ccapi.cpp
Outdated
| EXPECT_NO_THROW(ml::train::createLayer(ml::train::LayerType::LAYER_ADDITION)); | ||
| EXPECT_NO_THROW(ml::train::createLayer(ml::train::LayerType::LAYER_LOSS)); | ||
| EXPECT_NO_THROW(ml::train::layer::Input()); | ||
| EXPECT_NO_THROW(ml::train::layer::FullyConnected()); |
Added syntactic sugar constructors for optimizers which allow making optimizer closer to existing API and more readable. See also nnstreamer#734 **Self evaluation:** 1. Build test: [x]Passed [ ]Failed [ ]Skipped 2. Run test: [x]Passed [ ]Failed [ ]Skipped Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Added syntactic sugar constructors for layers and loss This allows creating various layers and losses directly with c++ API **Self evaluation:** 1. Build test: [x]Passed [ ]Failed [ ]Skipped 2. Run test: [x]Passed [ ]Failed [ ]Skipped Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
kparichay
force-pushed
the
cpp_syntactic_sugar
branch
from
897b36d
to
b83e273
Compare
kparichay
changed the title
Added syntactic sugar constructors for optimizers
which allow making optimizer closer to existing API
and more readable.
Resolves #734
Self evaluation:
Signed-off-by: Parichay Kapoor pk.kapoor@samsung.com