Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace duplicated use_harvest option by f0_extractor #160

Merged
merged 1 commit into from Nov 8, 2022

Conversation

taroushirani
Copy link
Contributor

Hello,

It seems that use_harvest option was replaced by f0_extractor since the commit 25b14a7, but the newest recipes of namine_ritsu_utagoe_db still make use of use_harvest option. This PR will fix it.

@r9y9 r9y9 added the bug fix label Nov 8, 2022
Copy link
Collaborator

@r9y9 r9y9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my bad again, thank you very much! LGTM.

@r9y9 r9y9 added the recipes label Nov 8, 2022
@r9y9 r9y9 added this to the v0.1.0 release milestone Nov 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022

Codecov Report

Merging #160 (2daf50e) into master (2fa5e30) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   64.42%   64.42%           
=======================================
  Files          39       39           
  Lines        5155     5155           
=======================================
  Hits         3321     3321           
  Misses       1834     1834           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@r9y9 r9y9 merged commit b6cebb6 into nnsvs:master Nov 8, 2022
@taroushirani taroushirani deleted the f0_extractor_fix_pr branch November 8, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants