Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MDN-based multi-stream models #172

Merged
merged 1 commit into from Nov 21, 2022
Merged

Fix MDN-based multi-stream models #172

merged 1 commit into from Nov 21, 2022

Conversation

r9y9
Copy link
Collaborator

@r9y9 r9y9 commented Nov 21, 2022

  • to support MDN-based F0 prediction models
  • to support non-MDN models for mgc/bap/mel feature streams
  • fix bug that predicted lf0 is used as the input of vuv prediction model during training
  • fix bug that sigma is passed to the vuv prediction model instead of mu durning inference

Fixes #171

- to support MDN-based F0 prediction models
- to support non-MDN models for mgc/bap/mel feature streams
- fix bug that predicted lf0 is used as the input of vuv prediction
  model during training
- fix bug that sigma is passed to the vuv prediction model instead of mu
  durning inference
@r9y9 r9y9 self-assigned this Nov 21, 2022
@r9y9 r9y9 added this to the v0.1.0 release milestone Nov 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2022

Codecov Report

Merging #172 (9fb3b24) into master (a370b37) will increase coverage by 0.03%.
The diff coverage is 79.54%.

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   63.70%   63.73%   +0.03%     
==========================================
  Files          39       39              
  Lines        5273     5303      +30     
==========================================
+ Hits         3359     3380      +21     
- Misses       1914     1923       +9     
Impacted Files Coverage Δ
nnsvs/train_util.py 8.82% <0.00%> (-0.04%) ⬇️
nnsvs/acoustic_models/multistream.py 96.85% <87.50%> (-1.18%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@r9y9 r9y9 merged commit 8b282f3 into master Nov 21, 2022
@r9y9 r9y9 deleted the fix-mdn-multi branch November 21, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants