Merge pull request #620 from no-chris/add-more-time-signatures

add support for more time signatures
no-chris · Feb 26, 2023 · beb7140 · beb7140
2 parents 1c6352e + f76f699
commit beb7140
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/packages/chord-mark/src/parser/matchers/isTimeSignatureString.js b/packages/chord-mark/src/parser/matchers/isTimeSignatureString.js
@@ -1,12 +1,20 @@
 const allowedTimeSignatures = [
 	'2/2',
 	'3/2',
+	'4/2',
 	'2/4',
 	'3/4',
 	'4/4',
 	'5/4',
+	'6/4',
+	'7/4',
+	'9/4',
+	'10/4',
 	'3/8',
+	'4/8',
+	'5/8',
 	'6/8',
+	'7/8',
 	'9/8',
 	'12/8',
 ];

diff --git a/packages/chord-mark/tests/unit/parser/matchers/isTimeSignatureString.spec.js b/packages/chord-mark/tests/unit/parser/matchers/isTimeSignatureString.spec.js
@@ -9,22 +9,28 @@ describe('isTimeSignatureString', () => {
 describe.each([
 	['2/2', true],
 	['3/2', true],
+	['4/2', true],
 
 	['2/4', true],
 	['3/4', true],
 	['4/4', true],
 	['5/4', true],
+	['6/4', true],
+	['7/4', true],
+	['9/4', true],
+	['10/4', true],
 
 	['3/8', true],
+	['5/8', true],
 	['6/8', true],
+	['7/8', true],
 	['9/8', true],
 	['12/8', true],
 
 	[' 4/4', false],
 	['4/4 ', false],
 	[' 4/4 ', false],
 
-	['5/2', false],
 	['3/3', false],
 	['13/8', false],
 ])('Time signature string %s', (tsString, result) => {

diff --git a/packages/chord-mark/tests/unit/parser/parseTimeSignature.spec.js b/packages/chord-mark/tests/unit/parser/parseTimeSignature.spec.js
@@ -29,7 +29,7 @@ describe.each([
 	});
 });
 
-describe.each([['2/1'], ['3/1'], ['5/8'], ['13/7']])(
+describe.each([['2/1'], ['3/1'], ['11/8'], ['13/7']])(
 	'Invalid time signature of %s',
 	(string) => {
 		test('Throws TypeError', () => {