New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align chords with lyrics #399

Merged

no-chris merged 11 commits into master from 387/position-chords-over-lyrics

Aug 29, 2021

+4,487 −2,789

Owner

no-chris commented Aug 29, 2021

No description provided.

no-chris added 7 commits

July 22, 2021 09:06


          prettify code

baef518


          parse chord position markers in lyric line

6c51cb7


          pass chordIndex and barIndex to forEachChordInChordLine handler

633aa17


          add chordLyrics spacer

95a15aa


          handle offset in chordline rendering

afa99cb


          Fix renderTextLine

5b0d979


          Add alignChordsWithLyrics rendering option

1660d24

no-chris self-assigned this

no-chris linked an issue

that may be closed by this pull request

Align chords with lyrics #387

Closed

no-chris added the enhancement label

coveralls commented Aug 29, 2021 •

edited

coverage: 100.0%. remained the same
when pulling ea9986c on 387/position-chords-over-lyrics
into 8a04978 on master.

no-chris added 3 commits

August 29, 2021 19:14


          rename textLine to lyricLine

7f764c3


          rename syntax.js to symbols.js

ea9986c


          reset spaces after for remaining chords in line

524b889

no-chris changed the title ~~387/position chords over lyrics~~ Align chords with lyrics


          update dependencies and build

96e455b

no-chris merged commit 12d7322 into master

no-chris deleted the 387/position-chords-over-lyrics branch

August 29, 2021 20:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment