Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export TypeScript types for parser and renderer factory functions #596

Merged
merged 1 commit into from Jan 26, 2023
Merged

Export TypeScript types for parser and renderer factory functions #596

merged 1 commit into from Jan 26, 2023

Conversation

darrylnoakes
Copy link
Contributor

The modules declared in JSDoc comments do not appear to be used by TypeScript, so all typing information disappeared in 4.0.0-beta.1 when the exports were removed.

I've improved them a little, as the original code seemed to be auto-generated.

…ctory functions

The modules declared in JSDoc comments do not appear to be used by
TypeScript, so all typing information disappeared in 4.0.0-beta.1 when
the exports were removed.

I've improved them a little, as the original code seemed to be auto-generated.
@no-chris no-chris self-assigned this Jan 26, 2023
@no-chris no-chris added the bug Something isn't working label Jan 26, 2023
@no-chris no-chris merged commit 29b83bf into no-chris:master Jan 26, 2023
@darrylnoakes darrylnoakes deleted the fix/factory-function-exports branch January 27, 2023 15:16
@no-chris no-chris changed the title fix(chord-symbol): export TypeScript types for parser and renderer factory functions Export TypeScript types for parser and renderer factory functions Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants