Explicit keywords #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think making the keyword behaviour explicit is probably a good idea. I'm not sure about this API, though. Perhaps it should be a nested object? moo.compile({
identifier: {match: /[a-zA-Z]+/, keywords: {keyword: ['moo', 'cow']}},
})Or with individual types: moo.compile({
identifier: {
match: /[a-zA-Z]+/,
keywords: {
'kw-class': 'class',
'kw-def': 'def',
'kw-if': 'if',
},
},
}) |
itt(['class', 'def', 'if'])
.map(k => ['kw-' + k, k])
.toObject()(Iterator adaptors solve every* problem!) |
nathan
reviewed
Jul 19, 2017
moo.js
Outdated
| (byLength[keyword.length] = byLength[keyword.length] || []).push(keyword) | ||
| }) | ||
|
|
||
| // fast string lookup |
There was a problem hiding this comment.
Have you profiled this as being faster than a plain old switch on the value?
There was a problem hiding this comment.
Not personally, but I've read that switching on the length first is faster.
There was a problem hiding this comment.
Nice! :-) |
I'm also not convinced having the object "backwards" like this, for consistency with the outer |
|
Let's do this. |
This was referenced Jul 21, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some thoughts on #53.
See the updated readme.