Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rotate.js creates malformed HTML #16

Closed
GuyPaddock opened this issue Nov 16, 2014 · 4 comments
Closed

rotate.js creates malformed HTML #16

GuyPaddock opened this issue Nov 16, 2014 · 4 comments

Comments

@GuyPaddock
Copy link
Collaborator

The example replaces the <head> tag with a style tag. I am guessing that the outer parameter should be false, or the tag should be included in the content that's added.
No9 added a commit that referenced this issue Apr 4, 2015
@No9
fix for #16 over writing the head tag
691bb9e
@No9
Copy link
Owner

No9 commented Apr 4, 2015

sorry forgot about this.
Yes your right so I fixed it.

@No9 No9 closed this as completed Apr 4, 2015
@tarkeshwars
Copy link

Hey @No9! I was trying the rotate example. It still replaces all the contents inside the head tag. Is it just me or the example isn't fixed?

@No9
Copy link
Owner

No9 commented Jul 18, 2015

Hi @tarkeshwars
Yes it replaces all the content inside the head but not the head tag itself.
That was the issue here.
If you want an example of how you can manipulate the contents of a tag see
https://github.com/No9/harmon/blob/master/examples/doge.js

Thanks

@tarkeshwars
Copy link

My bad! But the rotate example has confusing comments. I think they should
be fixed. I got around to looking at the doge file and that was exactly
what I needed. So thanks :)

On Sun, Jul 19, 2015, 12:43 AM Anton Whalley notifications@github.com
wrote:

Hi @tarkeshwars https://github.com/tarkeshwars
Yes it replaces all the content inside the head but not the head tag
itself.
That was the issue here.
If you want an example of how you can manipulate the contents of a tag see
https://github.com/No9/harmon/blob/master/examples/doge.js

Thanks

—
Reply to this email directly or view it on GitHub
#16 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@No9 @GuyPaddock @tarkeshwars