Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the GOES 16 and 17 readers #19

Merged
merged 2 commits into from
Jun 27, 2020
Merged

Update the GOES 16 and 17 readers #19

merged 2 commits into from
Jun 27, 2020

Conversation

bbakernoaa
Copy link
Member

fix: This adds a proper reader for the NOAA GOES 16 and GOES 17 L1 and L2 products. It also allows for reading of the GOES data both locally or from the amazon S3 server.

fix: This adds a proper reader for the NOAA GOES 16 and GOES 17 L1 and L2 products.  It also allows for reading of the GOES data both locally or from the amazon S3 server.
@bbakernoaa bbakernoaa added the enhancement New feature or request label Jun 17, 2020
@pep8speaks
Copy link

pep8speaks commented Jun 17, 2020

Hello @bbakernoaa! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 3:80: E501 line too long (86 > 79 characters)

Line 10:80: E501 line too long (110 > 79 characters)
Line 78:80: E501 line too long (97 > 79 characters)
Line 79:80: E501 line too long (80 > 79 characters)
Line 108:80: E501 line too long (84 > 79 characters)
Line 127:80: E501 line too long (97 > 79 characters)
Line 151:80: E501 line too long (87 > 79 characters)
Line 164:80: E501 line too long (83 > 79 characters)
Line 189:80: E501 line too long (89 > 79 characters)

Comment last updated at 2020-06-18 14:03:20 UTC

@bbakernoaa
Copy link
Member Author

The datasets can be easily be used like so

import monetio as mio
mio.goes.open_dataset(date='2020-05-10 22:00', satellite='16', product='ABI-L2-AODF')

There was an issue that the files had in that there are some points in the files that are not actually on the earth due to converage and array sizes.  This can cause problems when plotting as pcolormesh doesn't accept masked or non-finite valued arrays.  I simply filled the inf values with 1e30 so that they plot.
@bbakernoaa
Copy link
Member Author

@amcz @aring1988 Have either of you had time to look at this?

@bbakernoaa bbakernoaa merged commit 714efb2 into development Jun 27, 2020
@bbakernoaa bbakernoaa deleted the goes branch June 27, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants