Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hysplitdev #32

Merged
merged 3 commits into from
May 13, 2021
Merged

Hysplitdev #32

merged 3 commits into from
May 13, 2021

Conversation

amcz
Copy link
Collaborator

@amcz amcz commented May 13, 2021

Resolves issue #31. grid points in the HYSPLIT output cdump file represent the center of the sampling area.
This was coded correctly in the makegrid method in the ModelBin class. However, the get_latlongrid function was
shifting the location of the grid by half a grid point. Since get_latlongrid is utilized by the combine_dataset function
to align the files, this resulted in grid from combine_dataset being shifted half a grid point with respect to the when using
the open_dataset method.

@pep8speaks
Copy link

Hello @amcz! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 404:80: E501 line too long (101 > 79 characters)
Line 404:87: E231 missing whitespace after ','
Line 407:80: E501 line too long (101 > 79 characters)
Line 407:87: E231 missing whitespace after ','
Line 822:1: E302 expected 2 blank lines, found 1
Line 913:14: W291 trailing whitespace

@amcz amcz merged commit ef9c3c5 into development May 13, 2021
@amcz
Copy link
Collaborator Author

amcz commented May 13, 2021

Resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants